netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Santosh Shilimkar <santosh.shilimkar@oracle.com>
To: netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, davem@davemloft.net,
	ssantosh@kernel.org,
	Santosh Shilimkar <santosh.shilimkar@oracle.com>
Subject: [PATCH 05/15] RDS: increase size of hash-table to 8K
Date: Sat, 19 Sep 2015 19:04:42 -0400	[thread overview]
Message-ID: <1442703892-26692-6-git-send-email-santosh.shilimkar@oracle.com> (raw)
In-Reply-To: <1442703892-26692-1-git-send-email-santosh.shilimkar@oracle.com>

Even with per bucket locking scheme, in a massive parallel
system with active rds sockets which could be in excess of multiple
of 10K, rds_bin_lookup() workload is siginificant because of smaller
hashtable size.

With some tests, it was found that we get modest but still nice
reduction in rds_bind_lookup with bigger bucket.

	Hashtable	Baseline(1k)	Delta
	2048:		8.28%     	-2.45%
	4096:		8.28%		-4.60%
	8192:		8.28%		-6.46%
	16384:		8.28%		-6.75%

Based on the data, we set 8K as the bind hash-table size.

Signed-off-by: Santosh Shilimkar <ssantosh@kernel.org>
Signed-off-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
---
 net/rds/bind.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/net/rds/bind.c b/net/rds/bind.c
index bc6b93e..fb2d545 100644
--- a/net/rds/bind.c
+++ b/net/rds/bind.c
@@ -43,7 +43,7 @@ struct bind_bucket {
 	struct hlist_head	head;
 };
 
-#define BIND_HASH_SIZE 1024
+#define BIND_HASH_SIZE 8192
 static struct bind_bucket bind_hash_table[BIND_HASH_SIZE];
 
 static struct bind_bucket *hash_to_bucket(__be32 addr, __be16 port)
-- 
1.9.1

  parent reply	other threads:[~2015-09-19 23:04 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-19 23:04 [PATCH 00/15] RDS: connection scalability and performance improvements Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 01/15] RDS: use kfree_rcu in rds_ib_remove_ipaddr Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 02/15] RDS: make socket bind/release locking scheme simple and more efficient Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 03/15] RDS: fix rds_sock reference bug while doing bind Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 04/15] RDS: Use per-bucket rw lock for bind hash-table Santosh Shilimkar
2015-09-19 23:04 ` Santosh Shilimkar [this message]
2015-09-21  8:31   ` [PATCH 05/15] RDS: increase size of hash-table to 8K David Laight
2015-09-21 15:52     ` santosh shilimkar
2015-09-21 23:05   ` David Miller
2015-09-21 23:55     ` santosh shilimkar
2015-09-23 18:06       ` santosh shilimkar
2015-09-19 23:04 ` [PATCH 06/15] RDS: defer the over_batch work to send worker Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 07/15] RDS: use rds_send_xmit() state instead of RDS_LL_SEND_FULL Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 08/15] RDS: ack more receive completions to improve performance Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 09/15] RDS: split send completion handling and do batch ack Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 10/15] RDS: handle rds_ibdev release case instead of crashing the kernel Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 11/15] RDS: fix the rds_ib_fmr_wq kick call Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 12/15] RDS: use already available pool handle from ibmr Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 13/15] RDS: mark rds_ib_fmr_wq static Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 14/15] RDS: use max_mr from HCA caps than max_fmr Santosh Shilimkar
2015-09-19 23:04 ` [PATCH 15/15] RDS: split mr pool to improve 8K messages performance Santosh Shilimkar
2015-09-20  8:37 ` [PATCH 00/15] RDS: connection scalability and performance improvements Sagi Grimberg
     [not found]   ` <55FE7060.6010205-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-09-21 16:02     ` santosh shilimkar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442703892-26692-6-git-send-email-santosh.shilimkar@oracle.com \
    --to=santosh.shilimkar@oracle.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=ssantosh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).