From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: [PATCH net-next 0/9] net: Refactor ip_route_input_slow Date: Tue, 22 Sep 2015 15:55:14 -0700 Message-ID: <1442962523-3974-1-git-send-email-dsa@cumulusnetworks.com> Cc: David Ahern To: netdev@vger.kernel.org Return-path: Received: from mail-pa0-f54.google.com ([209.85.220.54]:36705 "EHLO mail-pa0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757828AbbIVWz3 (ORCPT ); Tue, 22 Sep 2015 18:55:29 -0400 Received: by pacbt3 with SMTP id bt3so3396589pac.3 for ; Tue, 22 Sep 2015 15:55:29 -0700 (PDT) Sender: netdev-owner@vger.kernel.org List-ID: ip_route_input_slow is a maze of gotos (9 of them!) making it error prone and difficult to read. This patchset refactors it, removing all but 2 of the labels. The brd_input label for broadcast path requires too many inputs to make a reasonble helper out of it so I left it as is. None of these patches change functionality, only move code around to make ip_route_input_slow more readable. Size comparison using gcc version 4.7.2 (Debian 4.7.2-5) With CONFIG_IP_ROUTE_VERBOSE: Before patches: $ size kbuild2/net/ipv4/route.o text data bss dec hex filename 20615 2321 32 22968 59b8 kbuild2/net/ipv4/route.o After patches: $ size kbuild/net/ipv4/route.o text data bss dec hex filename 20774 2321 32 23127 5a57 kbuild/net/ipv4/route.o An increase of 159 bytes with CONFIG_IP_ROUTE_VERBOSE. Without CONFIG_IP_ROUTE_VERBOSE: Before patches: $ size kbuild2/net/ipv4/route.o text data bss dec hex filename 19778 2321 32 22131 5673 kbuild2/net/ipv4/route.o After patches: $ size kbuild/net/ipv4/route.o text data bss dec hex filename 19858 2321 32 22211 56c3 kbuild/net/ipv4/route.o An increase of 80 bytes without CONFIG_IP_ROUTE_VERBOSE. David Ahern (9): net: Remove martian_source_keep_err goto label net: Remove e_inval label from ip_route_input_slow net: Remove e_nobufs label from ip_route_input_slow net: Move rth handling from ip_route_input_slow to helper net: Move martian_destination to helper net: Remove martian_source goto net: Remove martian_destination label net: Remove local_input label net: Remove no_route label net/ipv4/route.c | 239 ++++++++++++++++++++++++++++++++----------------------- 1 file changed, 139 insertions(+), 100 deletions(-) -- 1.9.1