From: David Woodhouse <dwmw2@infradead.org>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, romieu@fr.zoreil.com
Subject: Re: [PATCH 1/7] 8139cp: Improve accuracy of cp_interrupt() return, to survive IRQ storms
Date: Wed, 23 Sep 2015 20:45:30 +0100 [thread overview]
Message-ID: <1443037530.74600.29.camel@infradead.org> (raw)
In-Reply-To: <20150923.105812.149257816141624869.davem@davemloft.net>
[-- Attachment #1: Type: text/plain, Size: 2174 bytes --]
On Wed, 2015-09-23 at 10:58 -0700, David Miller wrote:
> From: David Woodhouse <dwmw2@infradead.org>
> Date: Wed, 23 Sep 2015 09:14:09 +0100
>
> > But sure, for now I'll drop this from the series and I can try to
> > convince you separately.
>
> Yes, let's discuss this independantly to the nice bug fixing
> that's happening in the rest of this series.
Since you explicitly call them 'bug fixes'... I suppose the last patch
in the latest series (enabling the various offloads by default) isn't a
bug fix and should be held back for net-next.
I think I can live with pushing the rest for the net tree. Just to
recap, the series is:
8139cp: Do not re-enable RX interrupts in cp_tx_timeout()
8139cp: Fix tx_queued debug message to print correct slot numbers
8139cp: Fix TSO/scatter-gather descriptor setup
8139cp: Reduce duplicate csum/tso code in cp_start_xmit()
8139cp: Fix DMA unmapping of transmitted buffers
8139cp: Dump contents of descriptor ring on TX timeout
8139cp: Enable offload features by default
The penultimate patch is also not strictly a bug fix, but it's only
adding additional diagnostics to a code path which was already broken
until I fixed it anyway, so I can live with that in net although I'll
also be happy if you want to defer it.
The fourth patch which removes the three duplicate versions of the
csum/tso checks might also be deferrable but really, it's *also*
fixing the failure mode when we see an inappropriate CHECKSUM_PARTIAL
packet, and it's touching a code path which I've *also* fixed in this
patch set. So it might as well stay.
I can shuffle things around if you disagree, but assuming Francois
concurs I'd suggest merging patches 1-6 (or just pulling from
git://git.infradead.org/users/dwmw2/linux-8139cp.git fixes-only)
and then I'll resubmit the last patch some time later, after you
next pull net into net-next.
Otherwise, please let me know if/how you'd like me to reorganise it.
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
[-- Attachment #2: smime.p7s --]
[-- Type: application/x-pkcs7-signature, Size: 5691 bytes --]
next prev parent reply other threads:[~2015-09-23 19:45 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-17 23:19 [PATCH 1/2] 8139cp: Use dev_kfree_skb_any() instead of dev_kfree_skb() in cp_clean_rings() David Woodhouse
2015-09-17 23:21 ` [PATCH 2/2] 8139cp: Call __cp_set_rx_mode() from cp_tx_timeout() David Woodhouse
2015-09-18 11:37 ` [PATCH 3/2] 8139cp: Improve accuracy of cp_interrupt() return, to survive IRQ storms David Woodhouse
2015-09-18 12:17 ` [PATCH 4/2] 8139cp: Do not re-enable RX interrupts in cp_tx_timeout() David Woodhouse
2015-09-21 5:24 ` [PATCH 2/2] 8139cp: Call __cp_set_rx_mode() from cp_tx_timeout() David Miller
2015-09-21 13:59 ` David Woodhouse
2015-09-21 14:01 ` [PATCH 1/7] 8139cp: Improve accuracy of cp_interrupt() return, to survive IRQ storms David Woodhouse
2015-09-21 20:25 ` Francois Romieu
2015-09-21 20:52 ` David Woodhouse
2015-09-22 23:45 ` David Miller
2015-09-23 8:14 ` David Woodhouse
2015-09-23 8:43 ` [PATCH 1/7] 8139cp: Do not re-enable RX interrupts in cp_tx_timeout() David Woodhouse
2015-09-23 8:44 ` [PATCH 2/7] 8139cp: Fix tx_queued debug message to print correct slot numbers David Woodhouse
2015-09-23 8:44 ` [PATCH 3/7] 8139cp: Fix TSO/scatter-gather descriptor setup David Woodhouse
2015-09-23 8:44 ` [PATCH 4/7] 8139cp: Reduce duplicate csum/tso code in cp_start_xmit() David Woodhouse
2015-09-23 8:45 ` [PATCH 5/7] 8139cp: Fix DMA unmapping of transmitted buffers David Woodhouse
2015-09-23 8:45 ` [PATCH 6/7] 8139cp: Dump contents of descriptor ring on TX timeout David Woodhouse
2015-09-23 8:46 ` [PATCH 7/7] 8139cp: Enable offload features by default David Woodhouse
2015-09-23 17:58 ` [PATCH 1/7] 8139cp: Improve accuracy of cp_interrupt() return, to survive IRQ storms David Miller
2015-09-23 19:45 ` David Woodhouse [this message]
2015-09-23 21:48 ` David Miller
2015-09-23 22:00 ` David Woodhouse
2015-09-23 23:29 ` Francois Romieu
2015-09-24 8:58 ` [PATCH WTF] 8139cp: Fix GSO MSS handling David Woodhouse
2015-09-24 10:38 ` [PATCH v2 RFC] " David Woodhouse
2015-09-24 12:05 ` Eric Dumazet
2015-09-24 12:31 ` David Woodhouse
2015-09-28 5:37 ` Tom Herbert
2015-09-28 7:21 ` David Woodhouse
2015-09-27 5:38 ` David Miller
2015-09-23 22:02 ` [PATCH] 8139cp: Set GSO max size and enforce it David Woodhouse
2015-09-23 22:44 ` [PATCH 1/7] 8139cp: Improve accuracy of cp_interrupt() return, to survive IRQ storms Francois Romieu
2015-09-23 23:09 ` David Woodhouse
2015-10-28 8:47 ` David Woodhouse
2015-09-23 22:44 ` Francois Romieu
2015-09-23 23:18 ` David Woodhouse
2015-09-21 14:02 ` [PATCH 2/7] 8139cp: Do not re-enable RX interrupts in cp_tx_timeout() David Woodhouse
2015-09-22 23:46 ` David Miller
2015-09-21 14:02 ` [PATCH 3/7] 8139cp: Fix tx_queued debug message to print correct slot numbers David Woodhouse
2015-09-21 14:02 ` [PATCH 4/7] 8139cp: Fix TSO/scatter-gather descriptor setup David Woodhouse
2015-09-21 21:01 ` Francois Romieu
2015-09-21 21:06 ` David Woodhouse
2015-09-21 21:47 ` David Woodhouse
2015-09-22 21:59 ` Francois Romieu
2015-09-21 14:03 ` [PATCH 5/7] 8139cp: Fix DMA unmapping of transmitted buffers David Woodhouse
2015-09-21 14:03 ` [PATCH 6/7] 8139cp: Dump contents of descriptor ring on TX timeout David Woodhouse
2015-09-21 14:05 ` [PATCH 7/7] 8139cp: Avoid gratuitous writes to TxPoll register when already running David Woodhouse
2015-09-21 20:54 ` Francois Romieu
2015-09-21 21:10 ` David Woodhouse
2015-09-21 14:11 ` [PATCH 2/2] 8139cp: Call __cp_set_rx_mode() from cp_tx_timeout() David Woodhouse
2015-09-21 5:24 ` [PATCH 1/2] 8139cp: Use dev_kfree_skb_any() instead of dev_kfree_skb() in cp_clean_rings() David Miller
[not found] <1443078810.74600.45.camel@infradead.org>
2015-09-24 7:25 ` [PATCH 1/7] 8139cp: Improve accuracy of cp_interrupt() return, to survive IRQ storms Francois Romieu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443037530.74600.29.camel@infradead.org \
--to=dwmw2@infradead.org \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=romieu@fr.zoreil.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).