From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: [PATCH v2 1/7] genirq: Fix the documentation of request_percpu_irq Date: Fri, 25 Sep 2015 18:09:32 +0200 Message-ID: <1443197378-30717-2-git-send-email-gregory.clement@free-electrons.com> References: <1443197378-30717-1-git-send-email-gregory.clement@free-electrons.com> Cc: Andrew Lunn , Sebastian Hesselbarth , Gregory CLEMENT , Lior Amsalem , Tawfik Bayouk , Nadav Haklai , Ezequiel Garcia , Maxime Ripard , Boris BREZILLON , Willy Tarreau , linux-arm-kernel@lists.infradead.org To: Thomas Gleixner , Jason Cooper , linux-kernel@vger.kernel.org, "David S. Miller" , netdev@vger.kernel.org, Thomas Petazzoni Return-path: In-Reply-To: <1443197378-30717-1-git-send-email-gregory.clement@free-electrons.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org From: Maxime Ripard The documentation of request_percpu_irq is confusing and suggest that the interrupt is not enabled at all, while it is actually enabled on the local CPU. Clarify that. Signed-off-by: Maxime Ripard Signed-off-by: Gregory CLEMENT --- kernel/irq/manage.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/kernel/irq/manage.c b/kernel/irq/manage.c index ad1b064f94fe..dc8a80ecfc4a 100644 --- a/kernel/irq/manage.c +++ b/kernel/irq/manage.c @@ -1790,9 +1790,10 @@ int setup_percpu_irq(unsigned int irq, struct irqaction *act) * @devname: An ascii name for the claiming device * @dev_id: A percpu cookie passed back to the handler function * - * This call allocates interrupt resources, but doesn't - * automatically enable the interrupt. It has to be done on each - * CPU using enable_percpu_irq(). + * This call allocates interrupt resources and enables the + * interrupt on the local CPU. If the interrupt is supposed to be + * enabled on other CPUs, it has to be done on each CPU using + * enable_percpu_irq(). * * Dev_id must be globally unique. It is a per-cpu variable, and * the handler gets called with the interrupted CPU's instance of -- 2.1.0