netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: netdev@vger.kernel.org
Cc: David Ahern <dsa@cumulusnetworks.com>
Subject: [PATCH net-next 06/11] net: Replace calls to vrf_dev_get_rth
Date: Mon, 28 Sep 2015 10:16:56 -0700	[thread overview]
Message-ID: <1443460621-24855-7-git-send-email-dsa@cumulusnetworks.com> (raw)
In-Reply-To: <1443460621-24855-1-git-send-email-dsa@cumulusnetworks.com>

Replace calls to vrf_dev_get_rth with l3mdev_get_rtable.
The check on the flow flags is handled in the l3mdev operation.

Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
---
 include/net/vrf.h | 22 ----------------------
 net/ipv4/route.c  |  8 +++-----
 2 files changed, 3 insertions(+), 27 deletions(-)

diff --git a/include/net/vrf.h b/include/net/vrf.h
index b05b96646e2a..5bba1535ba73 100644
--- a/include/net/vrf.h
+++ b/include/net/vrf.h
@@ -32,26 +32,4 @@ struct net_vrf {
 	u32			tb_id;
 };
 
-
-#if IS_ENABLED(CONFIG_NET_VRF)
-/* caller has already checked netif_is_l3_master(dev) */
-static inline struct rtable *vrf_dev_get_rth(const struct net_device *dev)
-{
-	struct rtable *rth = ERR_PTR(-ENETUNREACH);
-	struct net_vrf *vrf = netdev_priv(dev);
-
-	if (vrf) {
-		rth = vrf->rth;
-		atomic_inc(&rth->dst.__refcnt);
-	}
-	return rth;
-}
-
-#else
-static inline struct rtable *vrf_dev_get_rth(const struct net_device *dev)
-{
-	return ERR_PTR(-ENETUNREACH);
-}
-#endif
-
 #endif /* __LINUX_NET_VRF_H */
diff --git a/net/ipv4/route.c b/net/ipv4/route.c
index cf790aeb7f74..240f5ea02618 100644
--- a/net/ipv4/route.c
+++ b/net/ipv4/route.c
@@ -112,7 +112,6 @@
 #endif
 #include <net/secure_seq.h>
 #include <net/ip_tunnels.h>
-#include <net/vrf.h>
 #include <net/l3mdev.h>
 
 #define RT_FL_TOS(oldflp4) \
@@ -2128,11 +2127,10 @@ struct rtable *__ip_route_output_key(struct net *net, struct flowi4 *fl4)
 				fl4->saddr = inet_select_addr(dev_out, 0,
 							      RT_SCOPE_HOST);
 		}
-		if (netif_is_l3_master(dev_out) &&
-		    !(fl4->flowi4_flags & FLOWI_FLAG_VRFSRC)) {
-			rth = vrf_dev_get_rth(dev_out);
+
+		rth = l3mdev_get_rtable(dev_out, fl4);
+		if (rth)
 			goto out;
-		}
 	}
 
 	if (!fl4->daddr) {
-- 
1.9.1

  parent reply	other threads:[~2015-09-28 17:17 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-28 17:16 [PATCH net-next v2 00/11] net: L3 master device David Ahern
2015-09-28 17:16 ` [PATCH net-next 01/11] net: Rename IFF_VRF_MASTER to IFF_L3MDEV_MASTER David Ahern
2015-09-28 17:16 ` [PATCH net-next 02/11] net: Introduce L3 Master device abstraction David Ahern
2015-09-28 17:16 ` [PATCH net-next 03/11] net: Add support for l3mdev ops to VRF driver David Ahern
2015-09-28 17:16 ` [PATCH net-next 04/11] net: Replace vrf_master_ifindex{,_rcu} with l3mdev equivalents David Ahern
2015-09-28 17:16 ` [PATCH net-next 05/11] net: Replace vrf_dev_table and friends David Ahern
2015-09-28 17:16 ` David Ahern [this message]
2015-09-28 17:16 ` [PATCH net-next 07/11] net: Remove the now unused vrf_ptr David Ahern
2015-09-28 17:16 ` [PATCH net-next 08/11] net: Remove vrf header file David Ahern
2015-09-28 17:16 ` [PATCH net-next 09/11] net: Move netif_index_is_l3_master to l3mdev.h David Ahern
2015-09-28 17:17 ` [PATCH net-next 10/11] net: Rename FLOWI_FLAG_VRFSRC to FLOWI_FLAG_L3MDEV_SRC David Ahern
2015-09-28 17:17 ` [PATCH net-next 11/11] net: Add netif_is_l3_slave David Ahern
2015-09-29 23:23 ` [PATCH net-next v2 00/11] net: L3 master device David Miller
2015-09-29 23:52   ` David Ahern
  -- strict thread matches above, loose matches on Subject: below --
2015-09-30  3:07 [PATCH v3 net-next " David Ahern
2015-09-30  3:07 ` [PATCH net-next 06/11] net: Replace calls to vrf_dev_get_rth David Ahern
2015-09-25  0:20 [PATCH net-next 00/11] net: L3 master device David Ahern
2015-09-25  0:21 ` [PATCH net-next 06/11] net: Replace calls to vrf_dev_get_rth David Ahern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443460621-24855-7-git-send-email-dsa@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).