From: clsoto@linux.vnet.ibm.com
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, ogerlitz@mellanox.com,
brking@linux.vnet.ibm.com, amirv@mellanox.com,
Carol L Soto <clsoto@linux.vnet.ibm.com>
Subject: [PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq
Date: Tue, 29 Sep 2015 13:38:11 -0500 [thread overview]
Message-ID: <1443551891-17971-1-git-send-email-clsoto@linux.vnet.ibm.com> (raw)
From: Carol L Soto <clsoto@linux.vnet.ibm.com>
Test interrupts fails if not all completion vectors called
request_irq. This case can happen if only mlx4_en loads and
we have more completion vectors than rx rings.
Signed-off-by: Carol L Soto <clsoto@linux.vnet.ibm.com>
---
drivers/net/ethernet/mellanox/mlx4/eq.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/mellanox/mlx4/eq.c b/drivers/net/ethernet/mellanox/mlx4/eq.c
index 8e81e53..c344884 100644
--- a/drivers/net/ethernet/mellanox/mlx4/eq.c
+++ b/drivers/net/ethernet/mellanox/mlx4/eq.c
@@ -1364,6 +1364,10 @@ int mlx4_test_interrupts(struct mlx4_dev *dev)
* and performing a NOP command
*/
for(i = 0; !err && (i < dev->caps.num_comp_vectors); ++i) {
+ /* Make sure request_irq was called */
+ if (!priv->eq_table.eq[i].have_irq)
+ continue;
+
/* Temporary use polling for command completions */
mlx4_cmd_use_polling(dev);
--
1.8.3.1
next reply other threads:[~2015-09-29 18:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 18:38 clsoto [this message]
2015-10-04 8:03 ` [PATCH net-next] net/mlx4_core: Test interrupts fail if not all comp vectors called request_irq Or Gerlitz
2015-10-05 15:24 ` Carol Soto
2015-10-06 6:24 ` David Miller
-- strict thread matches above, loose matches on Subject: below --
2015-10-05 20:12 Or Gerlitz
2015-10-06 7:28 ` Matan Barak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443551891-17971-1-git-send-email-clsoto@linux.vnet.ibm.com \
--to=clsoto@linux.vnet.ibm.com \
--cc=amirv@mellanox.com \
--cc=brking@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).