* Rate limiting AP bandwidth change messages in ieee80211_config_bw?
@ 2015-09-30 17:02 Josh Boyer
2015-09-30 18:32 ` Johannes Berg
0 siblings, 1 reply; 5+ messages in thread
From: Josh Boyer @ 2015-09-30 17:02 UTC (permalink / raw)
To: Johannes Berg
Cc: drago01, linux-wireless@vger.kernel.org, netdev,
Linux-Kernel@Vger. Kernel. Org
Hi Johannes,
We've seen a handful of reports that seem to have verbose output from
the ieee80211_config_bw function in net/mac80211/mlme.c. It looks
similar to this:
[ 66.578652] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 2 (2447/0 MHz)
[ 68.522437] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 1 (2437/0 MHz)
[ 69.548353] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 2 (2447/0 MHz)
[ 70.568677] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 1 (2437/0 MHz)
[ 71.489416] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 2 (2447/0 MHz)
[ 72.512917] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 1 (2437/0 MHz)
[ 73.535866] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 2 (2447/0 MHz)
[ 81.777530] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 1 (2437/0 MHz)
[ 82.540576] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 2 (2447/0 MHz)
[ 94.513467] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 1 (2437/0 MHz)
[ 95.634855] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 2 (2447/0 MHz)
[ 97.474767] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 1 (2437/0 MHz)
[ 98.498036] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 2 (2447/0 MHz)
[ 99.520472] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 1 (2437/0 MHz)
[ 100.551344] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 2 (2447/0 MHz)
[ 101.571100] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 1 (2437/0 MHz)
[ 102.490708] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
is 2437 MHz, width 2 (2447/0 MHz)
Essentially, this looks like the AP is changing the bandwidth (and
only the width) every second or so. Why it is doing this, I'm not
sure. However, this doesn't seem to actually be an error case yet the
kernel logs are getting spammed with this message.
I'm wondering if we could either change this message to use sdata_dbg
instead of sdata_info, or if we could possibly ratelimit it somehow.
I'd be happy to come up with a patch for either, but I wanted to get
your feedback on it before I started. Do you have any objections or
preference?
josh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?
2015-09-30 17:02 Rate limiting AP bandwidth change messages in ieee80211_config_bw? Josh Boyer
@ 2015-09-30 18:32 ` Johannes Berg
2015-09-30 19:04 ` Johannes Berg
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2015-09-30 18:32 UTC (permalink / raw)
To: Josh Boyer
Cc: drago01, linux-wireless@vger.kernel.org, netdev,
Linux-Kernel@Vger. Kernel. Org
On Wed, 2015-09-30 at 13:02 -0400, Josh Boyer wrote:
> Hi Johannes,
>
> We've seen a handful of reports that seem to have verbose output from
> the ieee80211_config_bw function in net/mac80211/mlme.c. It looks
> similar to this:
>
> [ 66.578652] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
> is 2437 MHz, width 2 (2447/0 MHz)
> [ 68.522437] wlp3s0: AP xx:xx:xx:xx:xx changed bandwidth, new config
> is 2437 MHz, width 1 (2437/0 MHz)
> Essentially, this looks like the AP is changing the bandwidth (and
> only the width) every second or so. Why it is doing this, I'm not
> sure. However, this doesn't seem to actually be an error case yet the
> kernel logs are getting spammed with this message.
>
> I'm wondering if we could either change this message to use sdata_dbg
> instead of sdata_info, or if we could possibly ratelimit it somehow.
> I'd be happy to come up with a patch for either, but I wanted to get
> your feedback on it before I started. Do you have any objections or
> preference?
>
I'm not sure ratelimiting it would even work - it's not *that* high
frequency? Not really sure though.
I think we can do either, it's not such a terribly important message as
far as I can tell.
johannes
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?
2015-09-30 18:32 ` Johannes Berg
@ 2015-09-30 19:04 ` Johannes Berg
2015-10-01 0:09 ` Josh Boyer
0 siblings, 1 reply; 5+ messages in thread
From: Johannes Berg @ 2015-09-30 19:04 UTC (permalink / raw)
To: Josh Boyer
Cc: drago01, linux-wireless@vger.kernel.org, netdev,
Linux-Kernel@Vger. Kernel. Org
>
> I'm not sure ratelimiting it would even work - it's not *that* high
> frequency? Not really sure though.
>
> I think we can do either, it's not such a terribly important message as
> far as I can tell.
>
Seems like Emmanuel would like to see the message stay in some form -
perhaps we should try rate limiting it then? Could you check if that
actually works?
johannes
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?
2015-09-30 19:04 ` Johannes Berg
@ 2015-10-01 0:09 ` Josh Boyer
2015-10-01 7:48 ` Johannes Berg
0 siblings, 1 reply; 5+ messages in thread
From: Josh Boyer @ 2015-10-01 0:09 UTC (permalink / raw)
To: Johannes Berg
Cc: drago01, linux-wireless@vger.kernel.org, netdev,
Linux-Kernel@Vger. Kernel. Org
On Wed, Sep 30, 2015 at 3:04 PM, Johannes Berg
<johannes@sipsolutions.net> wrote:
>
>>
>> I'm not sure ratelimiting it would even work - it's not *that* high
>> frequency? Not really sure though.
>>
>> I think we can do either, it's not such a terribly important message as
>> far as I can tell.
>>
>
> Seems like Emmanuel would like to see the message stay in some form -
For what purpose? Or rather, when a user sees this in their dmesg,
what are they supposed to do about it?
> perhaps we should try rate limiting it then? Could you check if that
> actually works?
I'll think on it, sure. I was hoping sdata_dbg would be sufficient
because it's much easier, but if there's value in the message I can
look at limiting it in some fashion.
josh
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: Rate limiting AP bandwidth change messages in ieee80211_config_bw?
2015-10-01 0:09 ` Josh Boyer
@ 2015-10-01 7:48 ` Johannes Berg
0 siblings, 0 replies; 5+ messages in thread
From: Johannes Berg @ 2015-10-01 7:48 UTC (permalink / raw)
To: Josh Boyer
Cc: drago01, linux-wireless@vger.kernel.org, netdev,
Linux-Kernel@Vger. Kernel. Org
> For what purpose? Or rather, when a user sees this in their dmesg,
> what are they supposed to do about it?
I think the idea isn't that the user would do something, but more that
in case of performance issues, or perhaps driver/device bugs handling
the changes, or similar you'd have an indication that this happened.
> > perhaps we should try rate limiting it then? Could you check if
> > that
> > actually works?
>
> I'll think on it, sure. I was hoping sdata_dbg would be sufficient
> because it's much easier, but if there's value in the message I can
> look at limiting it in some fashion.
>
Thanks.
johannes
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2015-10-01 7:48 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-09-30 17:02 Rate limiting AP bandwidth change messages in ieee80211_config_bw? Josh Boyer
2015-09-30 18:32 ` Johannes Berg
2015-09-30 19:04 ` Johannes Berg
2015-10-01 0:09 ` Josh Boyer
2015-10-01 7:48 ` Johannes Berg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).