netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Nikolay Aleksandrov <razor@blackwall.org>
To: netdev@vger.kernel.org
Cc: bridge@lists.linux-foundation.org,
	Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
	roopa@cumulusnetworks.com, shm@cumulusnetworks.com,
	davem@davemloft.net
Subject: [PATCH net-next 02/20] bridge: netlink: export root id
Date: Sun,  4 Oct 2015 14:23:29 +0200	[thread overview]
Message-ID: <1443961427-15085-3-git-send-email-razor@blackwall.org> (raw)
In-Reply-To: <1443961427-15085-1-git-send-email-razor@blackwall.org>

From: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>

Add IFLA_BR_ROOT_ID and export br->designated_root via netlink. For this
purpose add struct ifla_bridge_id that would represent struct bridge_id.

Signed-off-by: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
---
 include/uapi/linux/if_link.h | 6 ++++++
 net/bridge/br_netlink.c      | 9 ++++++++-
 2 files changed, 14 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/if_link.h b/include/uapi/linux/if_link.h
index f7f480613555..03814371df44 100644
--- a/include/uapi/linux/if_link.h
+++ b/include/uapi/linux/if_link.h
@@ -233,11 +233,17 @@ enum {
 	IFLA_BR_VLAN_FILTERING,
 	IFLA_BR_VLAN_PROTOCOL,
 	IFLA_BR_GROUP_FWD_MASK,
+	IFLA_BR_ROOT_ID,
 	__IFLA_BR_MAX,
 };
 
 #define IFLA_BR_MAX	(__IFLA_BR_MAX - 1)
 
+struct ifla_bridge_id {
+	__u8	prio[2];
+	__u8	addr[6]; /* ETH_ALEN */
+};
+
 enum {
 	BRIDGE_MODE_UNSPEC,
 	BRIDGE_MODE_HAIRPIN,
diff --git a/net/bridge/br_netlink.c b/net/bridge/br_netlink.c
index 39b201a2bc12..7a3692469db6 100644
--- a/net/bridge/br_netlink.c
+++ b/net/bridge/br_netlink.c
@@ -854,6 +854,7 @@ static size_t br_get_size(const struct net_device *brdev)
 	       nla_total_size(sizeof(__be16)) +	/* IFLA_BR_VLAN_PROTOCOL */
 #endif
 	       nla_total_size(sizeof(u16)) +    /* IFLA_BR_GROUP_FWD_MASK */
+	       nla_total_size(sizeof(struct ifla_bridge_id)) +   /* IFLA_BR_ROOT_ID */
 	       0;
 }
 
@@ -868,6 +869,11 @@ static int br_fill_info(struct sk_buff *skb, const struct net_device *brdev)
 	u16 priority = (br->bridge_id.prio[0] << 8) | br->bridge_id.prio[1];
 	u16 group_fwd_mask = br->group_fwd_mask;
 	u8 vlan_enabled = br_vlan_enabled(br);
+	struct ifla_bridge_id root_id;
+
+	memset(&root_id, 0, sizeof(root_id));
+	memcpy(root_id.prio, br->designated_root.prio, sizeof(root_id.prio));
+	memcpy(root_id.addr, br->designated_root.addr, sizeof(root_id.addr));
 
 	if (nla_put_u32(skb, IFLA_BR_FORWARD_DELAY, forward_delay) ||
 	    nla_put_u32(skb, IFLA_BR_HELLO_TIME, hello_time) ||
@@ -876,7 +882,8 @@ static int br_fill_info(struct sk_buff *skb, const struct net_device *brdev)
 	    nla_put_u32(skb, IFLA_BR_STP_STATE, stp_enabled) ||
 	    nla_put_u16(skb, IFLA_BR_PRIORITY, priority) ||
 	    nla_put_u8(skb, IFLA_BR_VLAN_FILTERING, vlan_enabled) ||
-	    nla_put_u16(skb, IFLA_BR_GROUP_FWD_MASK, group_fwd_mask))
+	    nla_put_u16(skb, IFLA_BR_GROUP_FWD_MASK, group_fwd_mask) ||
+	    nla_put(skb, IFLA_BR_ROOT_ID, sizeof(root_id), &root_id))
 		return -EMSGSIZE;
 
 #ifdef CONFIG_BRIDGE_VLAN_FILTERING
-- 
2.4.3

  parent reply	other threads:[~2015-10-04 12:23 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-04 12:23 [PATCH net-next 00/20] bridge: complete netlink support Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 01/20] bridge: netlink: add group_fwd_mask support Nikolay Aleksandrov
2015-10-04 12:23 ` Nikolay Aleksandrov [this message]
2015-10-04 12:23 ` [PATCH net-next 03/20] bridge: netlink: export bridge id Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 04/20] bridge: netlink: export root port Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 05/20] bridge: netlink: export root path cost Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 06/20] bridge: netlink: export topology_change and topology_change_detected Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 07/20] bridge: netlink: export all timers Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 08/20] bridge: netlink: add group_addr support Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 09/20] bridge: netlink: add fdb flush Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 10/20] bridge: netlink: add support for multicast_router Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 11/20] bridge: netlink: add support for multicast_snooping Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 12/20] bridge: netlink: add support for multicast_query_use_ifaddr Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 13/20] bridge: netlink: add support for multicast_querier Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 14/20] bridge: netlink: add support for igmp's hash_elasticity Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 15/20] bridge: netlink: add support for igmp's hash_max Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 16/20] bridge: netlink: add support for multicast_last_member_count Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 17/20] bridge: netlink: add support for multicast_startup_query_count Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 18/20] bridge: netlink: add support for igmp's intervals Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 19/20] bridge: netlink: add support for netfilter tables config Nikolay Aleksandrov
2015-10-04 12:23 ` [PATCH net-next 20/20] bridge: netlink: add support for default_pvid Nikolay Aleksandrov
2015-10-04 23:47 ` [PATCH net-next 00/20] bridge: complete netlink support David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1443961427-15085-3-git-send-email-razor@blackwall.org \
    --to=razor@blackwall.org \
    --cc=bridge@lists.linux-foundation.org \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=nikolay@cumulusnetworks.com \
    --cc=roopa@cumulusnetworks.com \
    --cc=shm@cumulusnetworks.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).