netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Ahern <dsa@cumulusnetworks.com>
To: netdev@vger.kernel.org
Cc: steffen.klassert@secunet.com, David Ahern <dsa@cumulusnetworks.com>
Subject: [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6
Date: Mon,  5 Oct 2015 08:32:51 -0600	[thread overview]
Message-ID: <1444055571-82546-1-git-send-email-dsa@cumulusnetworks.com> (raw)

It occurred to me yesterday that 741a11d9e4103 ("net: ipv6: Add
RT6_LOOKUP_F_IFACE flag if oif is set") means that xfrm6_dst_lookup
needs the FLOWI_FLAG_SKIP_NH_OIF flag set. This latest commit causes
the oif to be considered in lookups which is known to break vti. This
explains why 58189ca7b274 did not the IPv6 change at the time it was
submitted.

Fixes: 42a7b32b73d6 ("xfrm: Add oif to dst lookups")
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
---
This is needed in 4.3.

 net/ipv6/xfrm6_policy.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/net/ipv6/xfrm6_policy.c b/net/ipv6/xfrm6_policy.c
index 30caa289c5db..5cedfda4b241 100644
--- a/net/ipv6/xfrm6_policy.c
+++ b/net/ipv6/xfrm6_policy.c
@@ -37,6 +37,7 @@ static struct dst_entry *xfrm6_dst_lookup(struct net *net, int tos, int oif,
 
 	memset(&fl6, 0, sizeof(fl6));
 	fl6.flowi6_oif = oif;
+	fl6.flowi6_flags = FLOWI_FLAG_SKIP_NH_OIF;
 	memcpy(&fl6.daddr, daddr, sizeof(fl6.daddr));
 	if (saddr)
 		memcpy(&fl6.saddr, saddr, sizeof(fl6.saddr));
-- 
1.9.1

             reply	other threads:[~2015-10-05 14:33 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 14:32 David Ahern [this message]
2015-10-07 11:25 ` [PATCH net-next] net: Fix vti use case with oif in dst lookups for IPv6 David Miller
2015-10-07 14:12   ` David Ahern
2015-10-09  6:54 ` Hajime Tazaki
2015-10-09  7:17   ` Steffen Klassert
2015-10-09 15:53     ` David Ahern
2015-10-09 17:27     ` David Ahern
2015-10-11 13:22       ` Hajime Tazaki
2015-10-11 13:31         ` David Ahern
2015-10-11 14:24           ` Hajime Tazaki
2015-10-11 18:01             ` David Ahern
2015-10-20 12:31               ` Hajime Tazaki
2015-10-20 17:48                 ` David Ahern
2015-10-21  2:38                   ` Hajime Tazaki
2015-10-12 18:49       ` David Ahern
2015-10-13 14:34         ` Steffen Klassert
2015-10-19  8:01         ` Steffen Klassert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444055571-82546-1-git-send-email-dsa@cumulusnetworks.com \
    --to=dsa@cumulusnetworks.com \
    --cc=netdev@vger.kernel.org \
    --cc=steffen.klassert@secunet.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).