netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, sfeldma@gmail.com, idosch@mellanox.com,
	eladr@mellanox.com, tgraf@suug.ch, ast@plumgrid.com,
	David.Laight@ACULAB.COM, john.fastabend@gmail.com
Subject: [patch net-next v2 08/13] rocker: set default world on port probe and clean world on remove
Date: Mon,  5 Oct 2015 19:44:01 +0200	[thread overview]
Message-ID: <1444067046-27825-9-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1444067046-27825-1-git-send-email-jiri@resnulli.us>

From: Jiri Pirko <jiri@mellanox.com>

Currently, there is only OF-DPA world supported in HW. So make this
would the default one for newly created rocker ports.

Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
v1->v2:
 - s/__rocker_port_change_world/rocker_port_change_world/
---
 drivers/net/ethernet/rocker/rocker_main.c | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/drivers/net/ethernet/rocker/rocker_main.c b/drivers/net/ethernet/rocker/rocker_main.c
index d950348..e0694ac 100644
--- a/drivers/net/ethernet/rocker/rocker_main.c
+++ b/drivers/net/ethernet/rocker/rocker_main.c
@@ -2175,6 +2175,7 @@ static struct rocker_world_ops *rocker_world_ops[] = {
 };
 
 #define ROCKER_WORLD_OPS_LEN ARRAY_SIZE(rocker_world_ops)
+#define ROCKER_DEFAULT_WORLD_OPS rocker_world_ops[0]
 
 struct rocker_world {
 	struct list_head list;
@@ -5198,6 +5199,7 @@ static void rocker_remove_ports(const struct rocker *rocker)
 			continue;
 		rocker_port_ig_tbl(rocker_port, NULL, ROCKER_OP_FLAG_REMOVE);
 		unregister_netdev(rocker_port->dev);
+		rocker_port_change_world(rocker_port, NULL);
 		free_netdev(rocker_port->dev);
 	}
 	kfree(rocker->ports);
@@ -5248,6 +5250,12 @@ static int rocker_probe_port(struct rocker *rocker, unsigned int port_number)
 
 	dev->features |= NETIF_F_NETNS_LOCAL | NETIF_F_SG;
 
+	err = rocker_port_change_world(rocker_port, ROCKER_DEFAULT_WORLD_OPS);
+	if (err) {
+		dev_err(&pdev->dev, "failed to set default world\n");
+		goto err_port_change_world;
+	}
+
 	err = register_netdev(dev);
 	if (err) {
 		dev_err(&pdev->dev, "register_netdev failed\n");
@@ -5282,6 +5290,8 @@ err_port_ig_tbl:
 	rocker->ports[port_number] = NULL;
 	unregister_netdev(dev);
 err_register_netdev:
+	rocker_port_change_world(rocker_port, NULL);
+err_port_change_world:
 	free_netdev(dev);
 	return err;
 }
-- 
1.9.3

  parent reply	other threads:[~2015-10-05 17:44 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-05 17:43 [patch net-next v2 00/13] rocker: add support for multiple worlds Jiri Pirko
2015-10-05 17:43 ` [patch net-next v2 01/13] rocker: remove unused rocker_port param from alloc funcs and shorten their names Jiri Pirko
2015-10-06  4:38   ` Scott Feldman
2015-10-05 17:43 ` [patch net-next v2 02/13] rocker: rename rocker.h to rocker_hw.h Jiri Pirko
2015-10-06  4:41   ` Scott Feldman
2015-10-05 17:43 ` [patch net-next v2 03/13] rocker: rename rocker.c to rocker_main.c Jiri Pirko
2015-10-06  4:45   ` Scott Feldman
2015-10-05 17:43 ` [patch net-next v2 04/13] rocker: push tlv processing into separate files Jiri Pirko
2015-10-06  4:47   ` Scott Feldman
2015-10-05 17:43 ` [patch net-next v2 05/13] rocker: implement set settings mode command Jiri Pirko
2015-10-05 17:43 ` [patch net-next v2 06/13] rocker: introduce worlds infrastructure Jiri Pirko
2015-10-06  5:16   ` Scott Feldman
2015-10-06  7:43     ` Jiri Pirko
2015-10-06 20:42       ` Rustad, Mark D
2015-10-05 17:44 ` [patch net-next v2 07/13] rocker: introduce OF-DPA world skeleton Jiri Pirko
2015-10-05 17:44 ` Jiri Pirko [this message]
2015-10-05 17:44 ` [patch net-next v2 09/13] rocker: pass "learning" value as a parameter to rocker_port_set_learning Jiri Pirko
2015-10-05 17:44 ` [patch net-next v2 10/13] rocker: pre-allocate wait structures during cmd ring init Jiri Pirko
2015-10-05 17:44 ` [patch net-next v2 11/13] rocker: remove trans parameter to rocker_cmd_exec function Jiri Pirko
2015-10-05 17:44 ` [patch net-next v2 12/13] rocker: call rocker_cmd_exec function with "nowait" boolean instead of flags Jiri Pirko
2015-10-05 17:44 ` [patch net-next v2 13/13] rocker: move OF-DPA stuff into separate file Jiri Pirko
2015-10-05 17:59   ` Scott Feldman
2015-10-06  3:56 ` [patch net-next v2 00/13] rocker: add support for multiple worlds Scott Feldman
2015-10-06  7:30   ` Jiri Pirko
2015-10-06 17:14     ` Scott Feldman
2015-10-07  6:03       ` Jiri Pirko
2015-10-07 16:53         ` Scott Feldman
2015-10-07 17:39           ` Jiri Pirko
2015-10-09 14:36             ` Jiri Pirko
2015-10-10  2:51               ` Scott Feldman
2015-10-10  7:21                 ` Jiri Pirko
2015-10-10  7:35                   ` Jiri Pirko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1444067046-27825-9-git-send-email-jiri@resnulli.us \
    --to=jiri@resnulli.us \
    --cc=David.Laight@ACULAB.COM \
    --cc=ast@plumgrid.com \
    --cc=davem@davemloft.net \
    --cc=eladr@mellanox.com \
    --cc=idosch@mellanox.com \
    --cc=john.fastabend@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=sfeldma@gmail.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).