From: Don Fry <pcnet32@frontier.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Oliver Neukum <oneukum@suse.com>,
linux-net-drivers@solarflare.com,
dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
netdev@vger.kernel.org, linux-parisc@vger.kernel.org,
linux-serial@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/15] pcnet32: use pci_set_dma_mask insted of pci_dma_supported
Date: Mon, 05 Oct 2015 20:57:54 -0700 [thread overview]
Message-ID: <1444103874.5667.7.camel@Lunix2.home> (raw)
In-Reply-To: <1443885579-7094-2-git-send-email-hch@lst.de>
On Sat, 2015-10-03 at 17:19 +0200, Christoph Hellwig wrote:
> This ensures the dma mask that is supported by the driver is recorded
> in the device structure.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> drivers/net/ethernet/amd/pcnet32.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Acked-by: Don Fry <pcnet32@frontier.com>
> diff --git a/drivers/net/ethernet/amd/pcnet32.c b/drivers/net/ethernet/amd/pcnet32.c
> index bc8b04f..e2afabf 100644
> --- a/drivers/net/ethernet/amd/pcnet32.c
> +++ b/drivers/net/ethernet/amd/pcnet32.c
> @@ -1500,7 +1500,7 @@ pcnet32_probe_pci(struct pci_dev *pdev, const struct pci_device_id *ent)
> return -ENODEV;
> }
>
> - if (!pci_dma_supported(pdev, PCNET32_DMA_MASK)) {
> + if (!pci_set_dma_mask(pdev, PCNET32_DMA_MASK)) {
> if (pcnet32_debug & NETIF_MSG_PROBE)
> pr_err("architecture does not support 32bit PCI busmaster DMA\n");
> return -ENODEV;
next prev parent reply other threads:[~2015-10-06 3:57 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 15:19 remove dma_supported and pci_dma_supported as public APIs Christoph Hellwig
2015-10-03 15:19 ` [PATCH 01/15] pcnet32: use pci_set_dma_mask insted of pci_dma_supported Christoph Hellwig
2015-10-06 3:57 ` Don Fry [this message]
2015-10-03 15:19 ` [PATCH 02/15] tw68-core: " Christoph Hellwig
2015-10-03 15:19 ` [PATCH 03/15] saa7164: " Christoph Hellwig
2015-10-03 15:19 ` [PATCH 04/15] saa7134: " Christoph Hellwig
[not found] ` <1443885579-7094-1-git-send-email-hch-jcswGhMUV9g@public.gmane.org>
2015-10-03 15:19 ` [PATCH 05/15] cx88: " Christoph Hellwig
2015-10-03 16:58 ` Mauro Carvalho Chehab
2015-10-03 15:19 ` [PATCH 06/15] cx25821: " Christoph Hellwig
2015-10-03 15:19 ` [PATCH 07/15] cx23885: " Christoph Hellwig
2015-10-03 15:19 ` [PATCH 08/15] netup_unidvb: " Christoph Hellwig
2015-10-07 8:03 ` Abylay Ospan
2015-10-03 15:19 ` [PATCH 09/15] mpsc: use dma_set_mask insted of dma_supported Christoph Hellwig
2015-10-03 15:19 ` [PATCH 10/15] nouveau: don't call pci_dma_supported Christoph Hellwig
2015-10-03 15:19 ` [PATCH 11/15] sfc: don't call dma_supported Christoph Hellwig
2015-10-05 15:08 ` Bert Kenward
2015-10-03 15:19 ` [PATCH 12/15] kaweth: remove ifdefed out call to dma_supported Christoph Hellwig
2015-10-03 15:19 ` [PATCH 13/15] usbnet: " Christoph Hellwig
2015-10-03 15:19 ` [PATCH 14/15] pci: remove pci_dma_supported Christoph Hellwig
2015-10-03 15:19 ` [PATCH 15/15] dma: remove external references to dma_supported Christoph Hellwig
2015-10-04 9:57 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444103874.5667.7.camel@Lunix2.home \
--to=pcnet32@frontier.com \
--cc=akpm@linux-foundation.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-net-drivers@solarflare.com \
--cc=linux-parisc@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=oneukum@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).