From: sfeldma@gmail.com
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, jiri@resnulli.us, siva.mannem.lnx@gmail.com,
pjonnala@broadcom.com, stephen@networkplumber.org,
roopa@cumulusnetworks.com, andrew@lunn.ch, f.fainelli@gmail.com,
vivien.didelot@savoirfairelinux.com
Subject: [PATCH net-next v2 0/4] switchdev: push bridge attributes down
Date: Wed, 7 Oct 2015 23:04:39 -0700 [thread overview]
Message-ID: <1444284283-33601-1-git-send-email-sfeldma@gmail.com> (raw)
From: Scott Feldman <sfeldma@gmail.com>
Push bridge-level attributes down to switchdev drivers. This patchset
adds the infrastructure and then pushes, as an example, ageing_time attribute
down from bridge to switchdev (rocker) driver. Add some range-checking
for ageing_time.
# ip link set dev br0 type bridge ageing_time 1000
# ip link set dev br0 type bridge ageing_time 999
RTNETLINK answers: Numerical result out of range
Up until now, switchdev attrs where port-level attrs, so the netdev used in
switchdev_attr_set() would be a switch port or bond of switch ports. With
bridge-level attrs, the netdev passed to switchdev_attr_set() is the bridge
netdev. The same recusive algo is used to visit the leaves of the stacked
drivers to set the attr, it's just in this case we start one layer higher in
the stack. One note is not all ports in the bridge may support setting a
bridge-level attribute, so rather than failing the entire set, we'll skip over
those ports returning -EOPNOTSUPP.
v1->v2: rebase w/ net-next
Scott Feldman (4):
switchdev: add bridge attributes
switchdev: skip over ports returning -EOPNOTSUPP when recursing ports
bridge: push bridge setting ageing_time down to switchdev
rocker: handle setting bridge ageing_time
drivers/net/ethernet/rocker/rocker.c | 22 ++++++++++++++++++++++
include/net/switchdev.h | 6 ++++++
include/uapi/linux/if_link.h | 2 +-
net/bridge/br_ioctl.c | 3 +--
net/bridge/br_netlink.c | 6 +++---
net/bridge/br_private.h | 1 +
net/bridge/br_stp.c | 24 ++++++++++++++++++++++++
net/bridge/br_sysfs_br.c | 3 +--
net/switchdev/switchdev.c | 9 ++++++++-
9 files changed, 67 insertions(+), 9 deletions(-)
--
1.7.10.4
next reply other threads:[~2015-10-08 6:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-08 6:04 sfeldma [this message]
2015-10-08 6:04 ` [PATCH net-next v2 1/4] switchdev: add bridge attributes sfeldma
2015-10-08 8:39 ` Jiri Pirko
2015-10-08 13:46 ` Vivien Didelot
2015-10-09 2:22 ` Scott Feldman
2015-10-08 6:04 ` [PATCH net-next v2 2/4] switchdev: skip over ports returning -EOPNOTSUPP when recursing ports sfeldma
2015-10-08 6:04 ` [PATCH net-next v2 3/4] bridge: push bridge setting ageing_time down to switchdev sfeldma
2015-10-08 6:04 ` [PATCH net-next v2 4/4] rocker: handle setting bridge ageing_time sfeldma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444284283-33601-1-git-send-email-sfeldma@gmail.com \
--to=sfeldma@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pjonnala@broadcom.com \
--cc=roopa@cumulusnetworks.com \
--cc=siva.mannem.lnx@gmail.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).