* [PATCH ethtool 1/2] Fix missing function declarations when building tests
@ 2015-10-09 3:03 Ben Hutchings
0 siblings, 0 replies; only message in thread
From: Ben Hutchings @ 2015-10-09 3:03 UTC (permalink / raw)
To: netdev
[-- Attachment #1: Type: text/plain, Size: 1451 bytes --]
Fix these compiler warnings by declaring test_exit() and test_main()
regardless of whether TEST_NO_WRAPPERS is defined:
test-cmdline.c: In function ‘send_ioctl’:
test-cmdline.c:268:2: warning: implicit declaration of function ‘test_exit’ [-Wimplicit-function-declaration]
test_exit(0);
^
test-common.c: In function ‘test_cmdline’:
test-common.c:361:21: warning: implicit declaration of function ‘test_main’ [-Wimplicit-function-declaration]
rc = rc ? rc - 1 : test_main(argc, argv);
^
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
These warnings are longstanding so I'm not sure why I didn't notice
them before! I've applied this post-4.2.
Ben.
internal.h | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/internal.h b/internal.h
index 444810d..156770c 100644
--- a/internal.h
+++ b/internal.h
@@ -132,10 +132,11 @@ struct cmd_expect {
int test_ioctl(const struct cmd_expect *expect, void *cmd);
#define TEST_IOCTL_MISMATCH (-2)
-#ifndef TEST_NO_WRAPPERS
int test_main(int argc, char **argp);
-#define main(...) test_main(__VA_ARGS__)
void test_exit(int rc) __attribute__((noreturn));
+
+#ifndef TEST_NO_WRAPPERS
+#define main(...) test_main(__VA_ARGS__)
#undef exit
#define exit(rc) test_exit(rc)
void *test_malloc(size_t size);
--
Ben Hutchings
If the facts do not conform to your theory, they must be disposed of.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 811 bytes --]
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-10-09 3:03 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-09 3:03 [PATCH ethtool 1/2] Fix missing function declarations when building tests Ben Hutchings
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).