From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andreas Schultz Subject: [PATCH net-next v4 1/2] fix return of iptunnel_xmit Date: Fri, 9 Oct 2015 11:27:37 +0200 Message-ID: <1444382858-6725-2-git-send-email-aschultz@tpip.net> References: <1444382858-6725-1-git-send-email-aschultz@tpip.net> Cc: Pravin B Shelar , "David S. Miller" To: netdev@vger.kernel.org Return-path: Received: from mail.tpip.net ([92.43.49.48]:37896 "EHLO mail.tpip.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965133AbbJIJ1q (ORCPT ); Fri, 9 Oct 2015 05:27:46 -0400 In-Reply-To: <1444382858-6725-1-git-send-email-aschultz@tpip.net> Sender: netdev-owner@vger.kernel.org List-ID: All users of iptunnel_xmit expect the return value to be the packet length on success (>0), negative for a tx error and zero for a tx dropped error. In cset 0e6fbc5b6c6218987c93b8c7ca60cf786062899d the negative return case was lost. This bug was introduced when the ip_tunnel_core code was refactored. Fixes: 0e6fbc5b6c6218987c93b8c7ca60cf786062899d Signed-off-by: Andreas Schultz Acked-by: Jiri Benc Acked-by: Pravin B Shelar --- Change in v2: - remove unused variable pkt_len Change in v3: - reworked based on comment from Jiri Benc Change in v4: - rebased to net-next to avoid merge conflicts - added Acked-By from Jiri Benc and Pravin B Shelar --- net/ipv4/ip_tunnel_core.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/net/ipv4/ip_tunnel_core.c b/net/ipv4/ip_tunnel_core.c index 6cb9009..453d569 100644 --- a/net/ipv4/ip_tunnel_core.c +++ b/net/ipv4/ip_tunnel_core.c @@ -80,9 +80,12 @@ int iptunnel_xmit(struct sock *sk, struct rtable *rt, struct sk_buff *skb, __ip_select_ident(net, iph, skb_shinfo(skb)->gso_segs ?: 1); err = ip_local_out(net, sk, skb); - if (unlikely(net_xmit_eval(err))) - pkt_len = 0; - return pkt_len; + if (likely(net_xmit_eval(err) == 0)) + return pkt_len; + if (err < 0) + return err; + + return 0; } EXPORT_SYMBOL_GPL(iptunnel_xmit); -- 2.1.4