From: Jiri Pirko <jiri@resnulli.us>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, idosch@mellanox.com, eladr@mellanox.com,
sfeldma@gmail.com, f.fainelli@gmail.com, linux@roeck-us.net,
vivien.didelot@savoirfairelinux.com, andrew@lunn.ch,
john.fastabend@gmail.com, David.Laight@ACULAB.COM,
stephen@networkplumber.org
Subject: [patch net-next v3 1/7] switchdev: assert rtnl in switchdev_port_obj_del
Date: Mon, 12 Oct 2015 17:45:44 +0200 [thread overview]
Message-ID: <1444664750-11260-2-git-send-email-jiri@resnulli.us> (raw)
In-Reply-To: <1444664750-11260-1-git-send-email-jiri@resnulli.us>
From: Jiri Pirko <jiri@mellanox.com>
RTNL mutex needs to be held for this function.
Safe usage of netdev_for_each_lower_dev requires that.
Signed-off-by: Jiri Pirko <jiri@mellanox.com>
---
net/switchdev/switchdev.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/switchdev/switchdev.c b/net/switchdev/switchdev.c
index 7a9ab90..a79ee44 100644
--- a/net/switchdev/switchdev.c
+++ b/net/switchdev/switchdev.c
@@ -366,6 +366,8 @@ EXPORT_SYMBOL_GPL(switchdev_port_obj_add);
* @dev: port device
* @id: object ID
* @obj: object to delete
+ *
+ * rtnl_lock must be held.
*/
int switchdev_port_obj_del(struct net_device *dev,
const struct switchdev_obj *obj)
@@ -375,6 +377,8 @@ int switchdev_port_obj_del(struct net_device *dev,
struct list_head *iter;
int err = -EOPNOTSUPP;
+ ASSERT_RTNL();
+
if (ops && ops->switchdev_port_obj_del)
return ops->switchdev_port_obj_del(dev, obj);
--
1.9.3
next prev parent reply other threads:[~2015-10-12 15:45 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 15:45 [patch net-next v3 0/7] switchdev: change locking Jiri Pirko
2015-10-12 15:45 ` Jiri Pirko [this message]
2015-10-12 15:45 ` [patch net-next v3 2/7] switchdev: introduce switchdev workqueue Jiri Pirko
2015-10-12 15:45 ` [patch net-next v3 3/7] switchdev: allow caller to explicitly request attr_set as deferred Jiri Pirko
2015-10-12 15:45 ` [patch net-next v3 4/7] switchdev: remove pointers from switchdev objects Jiri Pirko
2015-10-12 15:45 ` [patch net-next v3 5/7] switchdev: introduce possibility to defer obj_add/del Jiri Pirko
2015-10-12 15:45 ` [patch net-next v3 6/7] bridge: defer switchdev fdb del call in fdb_del_external_learn Jiri Pirko
2015-10-12 15:45 ` [patch net-next v3 7/7] rocker: remove nowait from switchdev callbacks Jiri Pirko
2015-10-12 15:57 ` [patch net-next v3 0/7] switchdev: change locking Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444664750-11260-2-git-send-email-jiri@resnulli.us \
--to=jiri@resnulli.us \
--cc=David.Laight@ACULAB.COM \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=eladr@mellanox.com \
--cc=f.fainelli@gmail.com \
--cc=idosch@mellanox.com \
--cc=john.fastabend@gmail.com \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=sfeldma@gmail.com \
--cc=stephen@networkplumber.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox