From: Joe Perches <joe@perches.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: huangdaode <huangdaode@hisilicon.com>,
davem@davemloft.net, liguozhu@hisilicon.com,
Yisen.Zhuang@huawei.com, netdev@vger.kernel.org,
linuxarm@huawei.com, salil.mehta@huawei.com,
kenneth-lee-2012@foxmail.com, xuwei5@hisilicon.com,
lisheng011@huawei.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro
Date: Mon, 12 Oct 2015 09:12:54 -0700 [thread overview]
Message-ID: <1444666374.9184.1.camel@perches.com> (raw)
In-Reply-To: <6398202.hrOAl1xuJE@wuerfel>
On Mon, 2015-10-12 at 13:59 +0200, Arnd Bergmann wrote:
> On Monday 12 October 2015 11:23:44 huangdaode wrote:
> > + s += sprintf(s,
> > + "\t\ttx_ring on %p:%u,%u,%u,%u,%u,%llu,%llu\n",
> > + h->qs[i]->tx_ring.io_base,
[]
> There is actually a more significant problem with this code, which I
> failed to notice when doing the original bugfix:
>
> You have a sysfs interface here that exports internal data of the
> device that should not be visible like this. One problem is that
> the io_base is a kernel pointer that must not be visible to non-root
> users (so we don't easily create an attack surface for exploits).
Using %pK might have been appropriate.
> It would probably be better to completely remove that sysfs interface, and
> to use the ethtool netlink interface to export them.
But this would be better.
next prev parent reply other threads:[~2015-10-12 16:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-12 3:23 [PATCH net-next v2 0/2] hisilicon net: fix some bugs in HNS drivers huangdaode
2015-10-12 3:23 ` [PATCH net-next v2 1/2] hisilicon net: removes the once HANDEL_TX_MSG macro huangdaode
2015-10-12 3:24 ` Joe Perches
2015-10-12 3:38 ` huangdaode
2015-10-12 11:53 ` Arnd Bergmann
2015-10-12 11:59 ` Arnd Bergmann
2015-10-12 16:12 ` Joe Perches [this message]
[not found] ` <561CAD6D.2060105@hisilicon.com>
2015-10-13 13:27 ` Fwd: " Kenneth Lee
2015-10-13 14:18 ` Arnd Bergmann
2015-10-15 15:32 ` Kenneth Lee
2015-10-12 3:23 ` [PATCH net-next v2 2/2] hisilicon net: fix a bug on Hisilicon Network Subsystem huangdaode
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1444666374.9184.1.camel@perches.com \
--to=joe@perches.com \
--cc=Yisen.Zhuang@huawei.com \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=huangdaode@hisilicon.com \
--cc=kenneth-lee-2012@foxmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lisheng011@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=salil.mehta@huawei.com \
--cc=xuwei5@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).