* [PATCH] nfc: free skb buffer using skb_free_datagram
@ 2015-10-19 15:59 Insu Yun
2015-10-19 16:44 ` Eric Dumazet
0 siblings, 1 reply; 2+ messages in thread
From: Insu Yun @ 2015-10-19 15:59 UTC (permalink / raw)
To: lauro.venancio, aloisio.almeida, sameo, davem, linux-wireless,
netdev, linux-kernel
Cc: taesoo, yeongjin.jang, insu, changwoo, Insu Yun
Freeing sk_buff genereated by skb_recv_datagram is always by
skb_free_datagram, not kfree_skb.
Signed-off-by: Insu Yun <wuninsu@gmail.com>
---
net/nfc/llcp_sock.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c
index b7de0da..15e681f 100644
--- a/net/nfc/llcp_sock.c
+++ b/net/nfc/llcp_sock.c
@@ -870,7 +870,7 @@ static int llcp_sock_recvmsg(struct socket *sock, struct msghdr *msg,
}
}
- kfree_skb(skb);
+ skb_free_datagram(sk, skb);
}
/* XXX Queue backlogged skbs */
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] nfc: free skb buffer using skb_free_datagram
2015-10-19 15:59 [PATCH] nfc: free skb buffer using skb_free_datagram Insu Yun
@ 2015-10-19 16:44 ` Eric Dumazet
0 siblings, 0 replies; 2+ messages in thread
From: Eric Dumazet @ 2015-10-19 16:44 UTC (permalink / raw)
To: Insu Yun
Cc: lauro.venancio, aloisio.almeida, sameo, davem, linux-wireless,
netdev, linux-kernel, taesoo, yeongjin.jang, insu, changwoo
On Mon, 2015-10-19 at 15:59 +0000, Insu Yun wrote:
> Freeing sk_buff genereated by skb_recv_datagram is always by
> skb_free_datagram, not kfree_skb.
>
> Signed-off-by: Insu Yun <wuninsu@gmail.com>
> ---
> net/nfc/llcp_sock.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/nfc/llcp_sock.c b/net/nfc/llcp_sock.c
> index b7de0da..15e681f 100644
> --- a/net/nfc/llcp_sock.c
> +++ b/net/nfc/llcp_sock.c
> @@ -870,7 +870,7 @@ static int llcp_sock_recvmsg(struct socket *sock, struct msghdr *msg,
> }
> }
>
> - kfree_skb(skb);
> + skb_free_datagram(sk, skb);
> }
>
> /* XXX Queue backlogged skbs */
Nope, you are adding a bug here.
Current code is fine.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-19 16:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-19 15:59 [PATCH] nfc: free skb buffer using skb_free_datagram Insu Yun
2015-10-19 16:44 ` Eric Dumazet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).