public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Joe Stringer <joestringer@nicira.com>
To: netdev@vger.kernel.org, pshelar@nicira.com
Cc: tgraf@suug.ch, jrajahalme@nicira.com
Subject: [PATCHv3 net 2/4] openvswitch: Clarify conntrack COMMIT behaviour
Date: Mon, 19 Oct 2015 19:18:58 -0700	[thread overview]
Message-ID: <1445307540-6786-2-git-send-email-joestringer@nicira.com> (raw)
In-Reply-To: <1445307540-6786-1-git-send-email-joestringer@nicira.com>

The presence of this attribute does not modify the ct_state for the
current packet, only future packets. Make this more clear in the header
definition.

Signed-off-by: Joe Stringer <joestringer@nicira.com>
---
v3: First post.
---
 include/uapi/linux/openvswitch.h | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/include/uapi/linux/openvswitch.h b/include/uapi/linux/openvswitch.h
index 036f73bc54cd..e663627a8ef3 100644
--- a/include/uapi/linux/openvswitch.h
+++ b/include/uapi/linux/openvswitch.h
@@ -620,7 +620,8 @@ struct ovs_action_hash {
  * enum ovs_ct_attr - Attributes for %OVS_ACTION_ATTR_CT action.
  * @OVS_CT_ATTR_COMMIT: If present, commits the connection to the conntrack
  * table. This allows future packets for the same connection to be identified
- * as 'established' or 'related'.
+ * as 'established' or 'related'. The flow key for the current packet will
+ * retain the pre-commit connection state.
  * @OVS_CT_ATTR_ZONE: u16 connection tracking zone.
  * @OVS_CT_ATTR_MARK: u32 value followed by u32 mask. For each bit set in the
  * mask, the corresponding bit in the value is copied to the connection
-- 
2.1.4

  reply	other threads:[~2015-10-20  2:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-20  2:18 [PATCHv3 net 1/4] openvswitch: Reject ct_state masks for unknown bits Joe Stringer
2015-10-20  2:18 ` Joe Stringer [this message]
2015-10-20  8:37   ` [PATCHv3 net 2/4] openvswitch: Clarify conntrack COMMIT behaviour Thomas Graf
2015-10-20 21:53   ` Pravin Shelar
2015-10-22  2:34   ` David Miller
2015-10-20  2:18 ` [PATCHv3 net 3/4] openvswitch: Mark connections new when not confirmed Joe Stringer
2015-10-20  8:41   ` Thomas Graf
2015-10-20 22:07   ` Pravin Shelar
2015-10-22  2:34   ` David Miller
2015-10-20  2:19 ` [PATCHv3 net 4/4] openvswitch: Serialize nested ct actions if provided Joe Stringer
2015-10-22  2:34   ` David Miller
2015-10-22  2:34 ` [PATCHv3 net 1/4] openvswitch: Reject ct_state masks for unknown bits David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445307540-6786-2-git-send-email-joestringer@nicira.com \
    --to=joestringer@nicira.com \
    --cc=jrajahalme@nicira.com \
    --cc=netdev@vger.kernel.org \
    --cc=pshelar@nicira.com \
    --cc=tgraf@suug.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox