From: Oliver Neukum <oneukum@suse.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: davem@davemloft.net, netdev@vger.kernel.org
Subject: Re: [PATCH] usbnet: removed USB_USBNET as a config option
Date: Tue, 20 Oct 2015 08:28:59 +0200 [thread overview]
Message-ID: <1445322539.2246.1.camel@suse.com> (raw)
In-Reply-To: <87oafuu0ru.fsf@nemi.mork.no>
On Mon, 2015-10-19 at 21:16 +0200, Bjørn Mork wrote:
> Oliver Neukum <oneukum@suse.com> writes:
>
> > usbnet drives no devices of its own. It makes more sense to
> > select it whenever a driver for actual hardware that needs
> > it is chosen rather than offer it as an option of its own.
> >
> > Signed-off-by: Oliver Neukum <oneukum@suse.com>
> > ---
> > drivers/net/usb/Kconfig | 75 +++++++++++++++----------------------------------
> > 1 file changed, 23 insertions(+), 52 deletions(-)
> >
> > diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> > index 8cf0eba..0cf45ab 100644
> > --- a/drivers/net/usb/Kconfig
> > +++ b/drivers/net/usb/Kconfig
> > @@ -119,42 +119,12 @@ config USB_LAN78XX
> > module will be called lan78xx.
> >
>
> This looks incomplete.
Yes, it is against the earlier patch set which introduces the CDC
parser in cdc-acm and cdc-wdm. In hindsight I should have reversed
the order of patches.
Regards
Oliver
next prev parent reply other threads:[~2015-10-20 6:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 12:23 [PATCH] usbnet: removed USB_USBNET as a config option Oliver Neukum
2015-10-19 19:16 ` Bjørn Mork
2015-10-20 6:28 ` Oliver Neukum [this message]
2015-10-20 8:43 ` Bjørn Mork
2015-10-20 10:24 ` Oliver Neukum
2015-10-20 11:03 ` Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445322539.2246.1.camel@suse.com \
--to=oneukum@suse.com \
--cc=bjorn@mork.no \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).