From: Hannes Frederic Sowa <hannes@stressinduktion.org>
To: Alexander Duyck <alexander.duyck@gmail.com>, netdev@vger.kernel.org
Subject: Re: [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU
Date: Mon, 26 Oct 2015 20:05:54 +0100 [thread overview]
Message-ID: <1445886354.991864.420737969.5EA6769F@webmail.messagingengine.com> (raw)
In-Reply-To: <562E5DD4.40908@gmail.com>
Hi Alex,
On Mon, Oct 26, 2015, at 18:07, Alexander Duyck wrote:
> Might be a bit longer. I just realized that I think there is another
> bug here where you are going through the NETDEV_UP path even though the
> interface isn't up. I'll run through some testing this morning to work
> out the kinks.
When you wrote this, I noticed that if someone removes the LL addresses
to disable the interface and raises the MTU again, we would also start
adding link-local addresses. Probably we need to safe the last state of
disable_ipv6 somewhere in the parent interface. :(
Maybe there is an easier solution for that.
Thanks for your patch, it looks cleaner!
Bye,
Hannes
next prev parent reply other threads:[~2015-10-26 19:06 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 14:36 [PATCH net-next] ipv6: recreate ipv6 link-local addresses when increasing MTU over IPV6_MIN_MTU Hannes Frederic Sowa
2015-10-26 15:52 ` Alexander Duyck
2015-10-26 16:05 ` Hannes Frederic Sowa
2015-10-26 17:07 ` Alexander Duyck
2015-10-26 17:21 ` Hannes Frederic Sowa
2015-10-26 19:05 ` Hannes Frederic Sowa [this message]
2015-10-26 16:33 ` Hannes Frederic Sowa
2015-10-26 19:16 ` Jay Vosburgh
2015-10-26 20:45 ` Hannes Frederic Sowa
2015-10-26 20:52 ` Alexander Duyck
2015-10-26 18:06 ` [net-next PATCH v2] " Alexander Duyck
2015-10-30 9:11 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445886354.991864.420737969.5EA6769F@webmail.messagingengine.com \
--to=hannes@stressinduktion.org \
--cc=alexander.duyck@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).