From: "Keller, Jacob E" <jacob.e.keller@intel.com>
To: "makita.toshiaki@lab.ntt.co.jp" <makita.toshiaki@lab.ntt.co.jp>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "stephen@networkplumber.org" <stephen@networkplumber.org>,
"toshiaki.makita1@gmail.com" <toshiaki.makita1@gmail.com>,
"kaber@trash.net" <kaber@trash.net>,
"vyasevich@gmail.com" <vyasevich@gmail.com>,
"intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Kirsher, Jeffrey T" <jeffrey.t.kirsher@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH net-next 0/4] Automatic adjustment of max frame size
Date: Mon, 26 Oct 2015 20:50:45 +0000 [thread overview]
Message-ID: <1445892645.15482.3.camel@intel.com> (raw)
In-Reply-To: <562D7A33.4020603@lab.ntt.co.jp>
On Mon, 2015-10-26 at 09:56 +0900, Toshiaki Makita wrote:
> On 2015/10/24 17:50, Toshiaki Makita wrote:
> > David,
> >
> > I found my patch set is marked with Changes Requested, but I
> > haven't
> > seen any feedback.
> >
> > Could you give me your feedback?
>
> Somehow the mail from LD Linux CI Server did not reach netdev mailing
> list so I could not have seen it from gmail...
>
> Toshiaki Makita
>
the ND Linux Bot is only checking against the Intel mailing list
intel-wired-lan@lists.osuosl.org, and isn't subscribed to netdev.
I am not sure why it failed to mail to it, unless netdev blocks non
subscribers from sending mail (it probably does)
The checkpatch output here is likely ignorable, note how it shows up as
a warning. You can fix them if you feel there is a reasonable way to
shorten the line. In this case, I probably wouldn't unless you want to
perform the VLAN and ETH_FRAME LEN calculation once somewhere else...
Generally being close to 80, (81,82 etc) is probably ok, as long as
there isn't an obvious nicer way to shorten the line.
Regards,
Jake
next prev parent reply other threads:[~2015-10-26 20:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-23 3:49 [PATCH net-next 0/4] Automatic adjustment of max frame size Toshiaki Makita
2015-10-23 3:49 ` [PATCH net-next 1/4] net: Add ndo_enc_hdr_len to notify extra header room for encapsulated frames Toshiaki Makita
2015-10-23 3:49 ` [PATCH net-next 2/4] e1000e: Add ndo_enc_hdr_len Toshiaki Makita
2015-10-23 3:49 ` [PATCH net-next 3/4] vlan: Notify real device of encap header length Toshiaki Makita
2015-10-23 3:49 ` [PATCH net-next 4/4] bridge: Notify port " Toshiaki Makita
2015-10-24 8:50 ` [PATCH net-next 0/4] Automatic adjustment of max frame size Toshiaki Makita
2015-10-26 0:56 ` Toshiaki Makita
2015-10-26 20:50 ` Keller, Jacob E [this message]
2015-10-27 0:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445892645.15482.3.camel@intel.com \
--to=jacob.e.keller@intel.com \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=kaber@trash.net \
--cc=makita.toshiaki@lab.ntt.co.jp \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=toshiaki.makita1@gmail.com \
--cc=vyasevich@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).