netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Stefan Lippers-Hollmann <s.l-h@gmx.de>, Dave Young <dyoung@redhat.com>
Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH] wireless: change cfg80211 regulatory domain info as debug messages
Date: Fri, 20 Nov 2015 12:55:33 +0100	[thread overview]
Message-ID: <1448020533.3141.27.camel@sipsolutions.net> (raw)
In-Reply-To: <20151115192547.3fd1b3cc@mir>

On Sun, 2015-11-15 at 19:25 +0100, Stefan Lippers-Hollmann wrote:
> Hi
> 
> On 2015-11-15, Dave Young wrote:
> > cfg80211 module prints a lot of messages like below. Actually
> > printing once is acceptable but sometimes it will print again and
> > again, it looks very annoying. It is better to change these detail
> > messages to debugging only.
> 
> It is a lot of info, easily repeated 3 times on boot, but it's also
> the only real chance to determine why you ended up with the
> regulatory domain settings you got, rather than just the values
> itself. Given that a lot (most?) of officially shipping wireless
> devices are misconfigured (wrong EEPROM regdom settings for the
> region they're sold in) and considering that the limits can even
> change at runtime (IEEE 802.11d), it is imho quite important not just
> to be able what the current restrictions (iw reg get) are, but also
> why the kernel settled on those.
> 

Hm. I kinda sympathize with both points of view here, not sure what to
do.

Maybe we could skip this for the world regdomain only? It doesn't
really change, and we typically don't care that much for it? That'd
probably get rid of most of the lines already.

Alternatively, perhaps the internal computations should be more
transparently visible through some other mechanism?

johannes

  parent reply	other threads:[~2015-11-20 11:55 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-15  7:31 [PATCH] wireless: change cfg80211 regulatory domain info as debug messages Dave Young
2015-11-15 17:38 ` Joe Perches
2015-11-16  1:59   ` Dave Young
     [not found]   ` <1447609134.6012.15.camel-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
2015-11-16 10:38     ` Johannes Berg
2015-11-15 18:25 ` Stefan Lippers-Hollmann
2015-11-16  1:58   ` Dave Young
2015-11-20 11:55   ` Johannes Berg [this message]
2015-11-23  1:37     ` Dave Young
     [not found]       ` <20151123013740.GA27383-0VdLhd/A9PnLJg/3yGtlgR/sF2h8X+2i0E9HWUfgJXw@public.gmane.org>
2015-12-11 14:26         ` Johannes Berg
2015-12-17  3:19           ` Dave Young
2015-12-17  7:58             ` Johannes Berg
2015-12-11 14:38 ` Johannes Berg
2015-12-17  3:16   ` Dave Young

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448020533.3141.27.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=davem@davemloft.net \
    --cc=dyoung@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=s.l-h@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).