netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "K. Y. Srinivasan" <kys@microsoft.com>
To: davem@davemloft.net, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org, devel@linuxdriverproject.org,
	olaf@aepfle.de, apw@canonical.com, jasowang@redhat.com
Subject: [PATCH net-next V2 14/17] hv_netvsc: Eliminate completion_func from struct hv_netvsc_packet
Date: Sat, 28 Nov 2015 12:20:42 -0800	[thread overview]
Message-ID: <1448742045-22732-14-git-send-email-kys@microsoft.com> (raw)
In-Reply-To: <1448742045-22732-1-git-send-email-kys@microsoft.com>

Eliminate completion_func from struct hv_netvsc_packet.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
---
 drivers/net/hyperv/hyperv_net.h   |    1 -
 drivers/net/hyperv/netvsc_drv.c   |    3 ---
 drivers/net/hyperv/rndis_filter.c |    1 -
 3 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/drivers/net/hyperv/hyperv_net.h b/drivers/net/hyperv/hyperv_net.h
index 65e340e..ddf51a0 100644
--- a/drivers/net/hyperv/hyperv_net.h
+++ b/drivers/net/hyperv/hyperv_net.h
@@ -137,7 +137,6 @@ struct hv_netvsc_packet {
 	u8 rmsg_size; /* RNDIS header and PPI size */
 	u8 rmsg_pgcnt; /* page count of RNDIS header and PPI */
 	u8 page_buf_cnt;
-	u8 completion_func;
 
 	u16 vlan_tci;
 	u16 q_idx;
diff --git a/drivers/net/hyperv/netvsc_drv.c b/drivers/net/hyperv/netvsc_drv.c
index eb0c6fa..bc4be1d 100644
--- a/drivers/net/hyperv/netvsc_drv.c
+++ b/drivers/net/hyperv/netvsc_drv.c
@@ -483,9 +483,6 @@ check_size:
 
 	memset(rndis_msg, 0, RNDIS_AND_PPI_SIZE);
 
-	/* Set the completion routine */
-	packet->completion_func = 1;
-
 	isvlan = packet->vlan_tci & VLAN_TAG_PRESENT;
 
 	/* Add the rndis header */
diff --git a/drivers/net/hyperv/rndis_filter.c b/drivers/net/hyperv/rndis_filter.c
index 0b98674..6ba5adf 100644
--- a/drivers/net/hyperv/rndis_filter.c
+++ b/drivers/net/hyperv/rndis_filter.c
@@ -236,7 +236,6 @@ static int rndis_filter_send_request(struct rndis_device *dev,
 			pb[0].len;
 	}
 
-	packet->completion_func = 0;
 	packet->xmit_more = false;
 
 	ret = netvsc_send(dev->net_dev->dev, packet, NULL, &pb, NULL);
-- 
1.7.4.1

  parent reply	other threads:[~2015-11-28 20:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28 20:20 [PATCH net-next V2 00/17] hv_netvsc: Eliminate the additional head room K. Y. Srinivasan
2015-11-28 20:20 ` [PATCH net-next V2 01/17] hv_netvsc: Resize some of the variables in hv_netvsc_packet K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 02/17] hv_netvsc: Rearrange the hv_negtvsc_packet to be space efficient K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 03/17] hv_netvsc: Eliminate the channel field in hv_netvsc_packet structure K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 04/17] hv_netvsc: Eliminate rndis_msg pointer from " K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 05/17] hv_netvsc: Eliminatte the data field from struct hv_netvsc_packet K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 06/17] hv_netvsc: Eliminate send_completion " K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 07/17] hv_netvsc: Eliminate send_completion_ctx " K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 08/17] hv_netvsc: Don't ask for additional head room in the skb K. Y. Srinivasan
2015-12-01 20:41     ` David Miller
2015-12-01 20:48       ` KY Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 09/17] hv_netvsc: move subchannel existence check to netvsc_select_queue() K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 10/17] hv_netvsc: remove locking in netvsc_send() K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 11/17] hv_netvsc: Eliminate page_buf from struct hv_netvsc_packet K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 12/17] hv_netvsc: Eliminate send_completion_tid " K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 13/17] hv_netvsc: Eliminate is_data_pkt " K. Y. Srinivasan
2015-11-28 20:20   ` K. Y. Srinivasan [this message]
2015-11-28 20:20   ` [PATCH net-next V2 15/17] hv_netvsc: Eliminate xmit_more " K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 16/17] hv_netvsc: Eliminate status " K. Y. Srinivasan
2015-11-28 20:20   ` [PATCH net-next V2 17/17] hv_netvsc: Eliminate vlan_tci " K. Y. Srinivasan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448742045-22732-14-git-send-email-kys@microsoft.com \
    --to=kys@microsoft.com \
    --cc=apw@canonical.com \
    --cc=davem@davemloft.net \
    --cc=devel@linuxdriverproject.org \
    --cc=jasowang@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=olaf@aepfle.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).