netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Abeni <pabeni@redhat.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
	"David S. Miller" <davem@davemloft.net>,
	Vlad Yasevich <vyasevich@gmail.com>,
	Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
	netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH net] ipv6: kill sk_dst_lock
Date: Mon, 30 Nov 2015 19:13:08 +0100	[thread overview]
Message-ID: <1448907188.5804.31.camel@redhat.com> (raw)
In-Reply-To: <1448901315.24696.127.camel@edumazet-glaptop2.roam.corp.google.com>

On Mon, 2015-11-30 at 08:35 -0800, Eric Dumazet wrote:
> ip6_sk_dst_lookup_flow() uses sk_dst_check() anyway, so the simplest
> way to fix the mess is to remove sk_dst_lock completely, as we did for
> IPv4.

Probably I'm missing something here, but why we don't need to sync the
update of sk_dst_cache and of dst_cookie (i.e. put them under the same
lock)?

Can't we end up with inconsistent values after concurrent udp
sendmsg() ? 

Cheers,

Paolo

  reply	other threads:[~2015-11-30 18:13 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-28 11:00 use-after-free in ip6_setup_cork Dmitry Vyukov
2015-11-28 17:11 ` Eric Dumazet
2015-11-28 17:23   ` Eric Dumazet
2015-11-30  3:29     ` Eric Dumazet
2015-11-30 16:35       ` [PATCH net] ipv6: kill sk_dst_lock Eric Dumazet
2015-11-30 18:13         ` Paolo Abeni [this message]
2015-11-30 18:27           ` Eric Dumazet
2015-12-01  1:44         ` YOSHIFUJI Hideaki
2015-12-01  2:01           ` Eric Dumazet
2015-12-03  4:42         ` David Miller
2015-12-03  5:53           ` [PATCH v2 " Eric Dumazet
2015-12-03 16:32             ` David Miller
2015-12-03 16:49               ` Eric Dumazet
2015-12-03 16:49                 ` Eric Dumazet
2015-12-03  5:57           ` [PATCH " Eric Dumazet
2015-11-30  3:37     ` [PATCH net] ipv6: add complete rcu protection around np->opt Eric Dumazet
2015-12-01 11:11       ` Hannes Frederic Sowa
2015-12-01 13:05         ` Eric Dumazet
2015-12-01 13:13           ` Hannes Frederic Sowa
2015-12-03  4:38       ` David Miller
2015-12-03  5:35         ` Eric Dumazet
2015-12-03  5:48           ` [PATCH net] ipv6: sctp: add " Eric Dumazet
2015-12-03 16:32             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1448907188.5804.31.camel@redhat.com \
    --to=pabeni@redhat.com \
    --cc=davem@davemloft.net \
    --cc=dvyukov@google.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=vyasevich@gmail.com \
    --cc=yoshfuji@linux-ipv6.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).