From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Mitch Williams <mitch.a.williams@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next 13/15] i40e/i40evf: use logical operator
Date: Thu, 3 Dec 2015 05:25:58 -0800 [thread overview]
Message-ID: <1449149160-105219-14-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1449149160-105219-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Mitch Williams <mitch.a.williams@intel.com>
We shouldn't be using a bitwise operator here; it's not a bitwise
operation. Use a logical operator instead. Why doesn't c have a
logical-or-and-assign operator?
Change-ID: Id84f3ca884910bed7073c84b1e16a102e958d0de
Signed-off-by: Mitch Williams <mitch.a.williams@intel.com>
Tested-by: Andrew Bowers <andrewx.bowers@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
drivers/net/ethernet/intel/i40evf/i40e_txrx.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
index 18a493e..be129d3 100644
--- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
@@ -1907,7 +1907,7 @@ int i40e_napi_poll(struct napi_struct *napi, int budget)
*/
i40e_for_each_ring(ring, q_vector->tx) {
clean_complete &= i40e_clean_tx_irq(ring, vsi->work_limit);
- arm_wb |= ring->arm_wb;
+ arm_wb = arm_wb || ring->arm_wb;
ring->arm_wb = false;
}
diff --git a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
index 4f1ac86..b53333a 100644
--- a/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
+++ b/drivers/net/ethernet/intel/i40evf/i40e_txrx.c
@@ -1331,7 +1331,7 @@ int i40evf_napi_poll(struct napi_struct *napi, int budget)
*/
i40e_for_each_ring(ring, q_vector->tx) {
clean_complete &= i40e_clean_tx_irq(ring, vsi->work_limit);
- arm_wb |= ring->arm_wb;
+ arm_wb = arm_wb || ring->arm_wb;
ring->arm_wb = false;
}
--
2.5.0
next prev parent reply other threads:[~2015-12-03 13:26 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-03 13:25 [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2015-12-03 Jeff Kirsher
2015-12-03 13:25 ` [net-next 01/15] i40evf: increase max number of queues Jeff Kirsher
2015-12-03 13:25 ` [net-next 02/15] i40evf: set real num queues Jeff Kirsher
2015-12-03 13:25 ` [net-next 03/15] i40evf: remove duplicate string Jeff Kirsher
2015-12-03 13:25 ` [net-next 04/15] i40e: Detection and recovery of TX queue hung logic moved to service_task from tx_timeout Jeff Kirsher
2015-12-03 13:25 ` [net-next 05/15] i40e: Fix memory leaks, sideband filter programming Jeff Kirsher
2015-12-03 13:25 ` [net-next 06/15] i40evf: don't use atomic allocation Jeff Kirsher
2015-12-03 13:25 ` [net-next 07/15] i40e: propagate properly Jeff Kirsher
2015-12-03 13:25 ` [net-next 08/15] i40evf: use correct types Jeff Kirsher
2015-12-03 13:25 ` [net-next 09/15] i40e: use priv flags to control packet split Jeff Kirsher
2015-12-05 21:25 ` Or Gerlitz
2015-12-08 23:24 ` Jesse Brandeburg
2015-12-08 23:33 ` Or Gerlitz
2015-12-03 13:25 ` [net-next 10/15] i40e: remove CONFIG_I40E_VXLAN Jeff Kirsher
2015-12-03 13:25 ` [net-next 11/15] i40e: Remove separate functions gathering XOFF Rx stats Jeff Kirsher
2015-12-03 13:25 ` [net-next 12/15] i40e: fix whitespace Jeff Kirsher
2015-12-03 13:25 ` Jeff Kirsher [this message]
2015-12-03 13:25 ` [net-next 14/15] i40e/i40evf: Bump version to 1.4.7 for i40e and 1.4.3 for i40evf Jeff Kirsher
2015-12-03 13:26 ` [net-next 15/15] i40e: trivial fixes Jeff Kirsher
2015-12-03 17:11 ` [net-next 00/15][pull request] 40GbE Intel Wired LAN Driver Updates 2015-12-03 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449149160-105219-14-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jogreene@redhat.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).