From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hannes Frederic Sowa Subject: Re: [PATCH v1 1/6] net: Generalize udp based tunnel offload Date: Fri, 04 Dec 2015 21:02:46 +0100 Message-ID: <1449259366.7087.458357513.2858FD5A@webmail.messagingengine.com> References: <1448312579-159544-1-git-send-email-anjali.singhai@intel.com> <1448312579-159544-2-git-send-email-anjali.singhai@intel.com> <20151129.222138.1582847465760563254.davem@davemloft.net> <20151201154445.GF29497@tuxdriver.com> <1448984968.3382143.454794705.68D88B7D@webmail.messagingengine.com> <1449074114.3806253.455834737.16948E5F@webmail.messagingengine.com> <1449158374.11080.456996721.69F803D7@webmail.messagingengine.com> <1449259145.6236.458303617.55CF2C4E@webmail.messagingengine.com> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: 7bit Cc: "John W. Linville" , Jesse Gross , David Miller , Anjali Singhai Jain , Linux Kernel Network Developers , Kiran Patil To: Tom Herbert Return-path: Received: from out4-smtp.messagingengine.com ([66.111.4.28]:37924 "EHLO out4-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753329AbbLDUCs (ORCPT ); Fri, 4 Dec 2015 15:02:48 -0500 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 43CB2205E1 for ; Fri, 4 Dec 2015 15:02:47 -0500 (EST) In-Reply-To: <1449259145.6236.458303617.55CF2C4E@webmail.messagingengine.com> Sender: netdev-owner@vger.kernel.org List-ID: On Fri, Dec 4, 2015, at 20:59, Hannes Frederic Sowa wrote: > And then filling out those fields using the offsetof and sizeof of the > headers, but this seemed to be very difficult a) because they use > bitmasks (which of course could be converted) or in case of IPv6 a > schema would have to be specified how to walk down the IPv6 extensions. > This seems also to be true for NSH. Maybe gcc could help with > compile-time introspection with bitfields in the future but I doubt that > for now. Duplicating and maintaining two header structs for one > tunneling protoco Seems like I accidentally removed something here: I wanted to write that maintaining multiple descriptions of tunneling headers seems not worthwhile for now. Bye, Hannes