netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
	netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
	jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 12/15] fm10k: use macro for default Tx and Rx ITR values
Date: Sun,  6 Dec 2015 00:01:31 -0800	[thread overview]
Message-ID: <1449388894-128573-13-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1449388894-128573-1-git-send-email-jeffrey.t.kirsher@intel.com>

From: Jacob Keller <jacob.e.keller@intel.com>

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
 drivers/net/ethernet/intel/fm10k/fm10k.h         | 2 ++
 drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c | 4 ++--
 drivers/net/ethernet/intel/fm10k/fm10k_pci.c     | 4 ++--
 3 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/intel/fm10k/fm10k.h b/drivers/net/ethernet/intel/fm10k/fm10k.h
index bb799b3..115033f 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k.h
+++ b/drivers/net/ethernet/intel/fm10k/fm10k.h
@@ -175,6 +175,8 @@ struct fm10k_ring_container {
 
 #define ITR_IS_ADAPTIVE(itr) (!!(itr & FM10K_ITR_ADAPTIVE))
 
+#define FM10K_TX_ITR_DEFAULT	FM10K_ITR_10K
+#define FM10K_RX_ITR_DEFAULT	FM10K_ITR_20K
 #define FM10K_ITR_ENABLE	(FM10K_ITR_AUTOMASK | FM10K_ITR_MASK_CLEAR)
 
 static inline struct netdev_queue *txring_txq(const struct fm10k_ring *ring)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
index a505a50..109e211 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_ethtool.c
@@ -729,10 +729,10 @@ static int fm10k_set_coalesce(struct net_device *dev,
 
 	/* set initial values for adaptive ITR */
 	if (ec->use_adaptive_tx_coalesce)
-		tx_itr = FM10K_ITR_ADAPTIVE | FM10K_ITR_10K;
+		tx_itr = FM10K_ITR_ADAPTIVE | FM10K_TX_ITR_DEFAULT;
 
 	if (ec->use_adaptive_rx_coalesce)
-		rx_itr = FM10K_ITR_ADAPTIVE | FM10K_ITR_20K;
+		rx_itr = FM10K_ITR_ADAPTIVE | FM10K_RX_ITR_DEFAULT;
 
 	/* update interface */
 	interface->tx_itr = tx_itr;
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
index 1f0d9bc..0cdb79e8 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
@@ -1771,8 +1771,8 @@ static int fm10k_sw_init(struct fm10k_intfc *interface,
 	interface->rx_ring_count = FM10K_DEFAULT_RXD;
 
 	/* set default interrupt moderation */
-	interface->tx_itr = FM10K_ITR_10K;
-	interface->rx_itr = FM10K_ITR_ADAPTIVE | FM10K_ITR_20K;
+	interface->tx_itr = FM10K_TX_ITR_DEFAULT;
+	interface->rx_itr = FM10K_ITR_ADAPTIVE | FM10K_RX_ITR_DEFAULT;
 
 	/* initialize vxlan_port list */
 	INIT_LIST_HEAD(&interface->vxlan_port);
-- 
2.5.0

  parent reply	other threads:[~2015-12-06  8:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-06  8:01 [net-next v2 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2015-12-05 Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 01/15] fm10k: set netdev features in one location Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 02/15] fm10k: reset max_queues on init_hw_vf failure Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 03/15] fm10k: always check init_hw for errors Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 04/15] fm10k: reinitialize queuing scheme after calling init_hw Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 05/15] fm10k: Correct typecast in fm10k_update_xc_addr_pf Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 06/15] fm10k: explicitly typecast vlan values to u16 Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 07/15] fm10k: add statistics for actual DWORD count of mbmem mailbox Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 08/15] fm10k: rename mbx_tx_oversized statistic to mbx_tx_dropped Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 09/15] fm10k: Add support for ITR scaling based on PCIe link speed Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 10/15] fm10k: introduce ITR_IS_ADAPTIVE macro Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 11/15] fm10k: Update adaptive ITR algorithm Jeff Kirsher
2015-12-06  8:01 ` Jeff Kirsher [this message]
2015-12-06  8:01 ` [net-next v2 13/15] fm10k: change default Tx ITR to 25usec Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 14/15] fm10k: TRIVIAL fix typo of hardware Jeff Kirsher
2015-12-06  8:01 ` [net-next v2 15/15] fm10k: TRIVIAL cleanup order at top of fm10k_xmit_frame Jeff Kirsher
2015-12-06 16:23 ` [net-next v2 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2015-12-05 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1449388894-128573-13-git-send-email-jeffrey.t.kirsher@intel.com \
    --to=jeffrey.t.kirsher@intel.com \
    --cc=davem@davemloft.net \
    --cc=jacob.e.keller@intel.com \
    --cc=jogreene@redhat.com \
    --cc=netdev@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=sassmann@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).