From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: davem@davemloft.net
Cc: Jacob Keller <jacob.e.keller@intel.com>,
netdev@vger.kernel.org, nhorman@redhat.com, sassmann@redhat.com,
jogreene@redhat.com, Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: [net-next v2 04/15] fm10k: reinitialize queuing scheme after calling init_hw
Date: Sun, 6 Dec 2015 00:01:23 -0800 [thread overview]
Message-ID: <1449388894-128573-5-git-send-email-jeffrey.t.kirsher@intel.com> (raw)
In-Reply-To: <1449388894-128573-1-git-send-email-jeffrey.t.kirsher@intel.com>
From: Jacob Keller <jacob.e.keller@intel.com>
The init_hw function may fail, and in the case of VFs, it might change
the number of maximum queues available. Thus, for every flow which
checks init_hw, we need to ensure that we clear the queue scheme before,
and initialize it after. The fm10k_io_slot_reset path will end up
triggering a reset so fm10k_reinit needs this change. The
fm10k_io_error_detected and fm10k_io_resume also need to properly clear
and reinitialize the queue scheme.
Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Reviewed-by: Bruce Allan <bruce.w.allan@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
---
drivers/net/ethernet/intel/fm10k/fm10k_pci.c | 18 ++++++++++++++++++
1 file changed, 18 insertions(+)
diff --git a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
index 9c21d1e..faf8149 100644
--- a/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
+++ b/drivers/net/ethernet/intel/fm10k/fm10k_pci.c
@@ -159,6 +159,9 @@ static void fm10k_reinit(struct fm10k_intfc *interface)
fm10k_mbx_free_irq(interface);
+ /* free interrupts */
+ fm10k_clear_queueing_scheme(interface);
+
/* delay any future reset requests */
interface->last_reset = jiffies + (10 * HZ);
@@ -175,6 +178,12 @@ static void fm10k_reinit(struct fm10k_intfc *interface)
goto reinit_err;
}
+ err = fm10k_init_queueing_scheme(interface);
+ if (err) {
+ dev_err(&interface->pdev->dev, "init_queueing_scheme failed: %d\n", err);
+ goto reinit_err;
+ }
+
/* reassociate interrupts */
fm10k_mbx_request_irq(interface);
@@ -2198,6 +2207,9 @@ static pci_ers_result_t fm10k_io_error_detected(struct pci_dev *pdev,
if (netif_running(netdev))
fm10k_close(netdev);
+ /* free interrupts */
+ fm10k_clear_queueing_scheme(interface);
+
fm10k_mbx_free_irq(interface);
pci_disable_device(pdev);
@@ -2270,6 +2282,12 @@ static void fm10k_io_resume(struct pci_dev *pdev)
/* reset statistics starting values */
hw->mac.ops.rebind_hw_stats(hw, &interface->stats);
+ err = fm10k_init_queueing_scheme(interface);
+ if (err) {
+ dev_err(&interface->pdev->dev, "init_queueing_scheme failed: %d\n", err);
+ return;
+ }
+
/* reassociate interrupts */
fm10k_mbx_request_irq(interface);
--
2.5.0
next prev parent reply other threads:[~2015-12-06 8:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-06 8:01 [net-next v2 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2015-12-05 Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 01/15] fm10k: set netdev features in one location Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 02/15] fm10k: reset max_queues on init_hw_vf failure Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 03/15] fm10k: always check init_hw for errors Jeff Kirsher
2015-12-06 8:01 ` Jeff Kirsher [this message]
2015-12-06 8:01 ` [net-next v2 05/15] fm10k: Correct typecast in fm10k_update_xc_addr_pf Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 06/15] fm10k: explicitly typecast vlan values to u16 Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 07/15] fm10k: add statistics for actual DWORD count of mbmem mailbox Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 08/15] fm10k: rename mbx_tx_oversized statistic to mbx_tx_dropped Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 09/15] fm10k: Add support for ITR scaling based on PCIe link speed Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 10/15] fm10k: introduce ITR_IS_ADAPTIVE macro Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 11/15] fm10k: Update adaptive ITR algorithm Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 12/15] fm10k: use macro for default Tx and Rx ITR values Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 13/15] fm10k: change default Tx ITR to 25usec Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 14/15] fm10k: TRIVIAL fix typo of hardware Jeff Kirsher
2015-12-06 8:01 ` [net-next v2 15/15] fm10k: TRIVIAL cleanup order at top of fm10k_xmit_frame Jeff Kirsher
2015-12-06 16:23 ` [net-next v2 00/15][pull request] 100GbE Intel Wired LAN Driver Updates 2015-12-05 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449388894-128573-5-git-send-email-jeffrey.t.kirsher@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=davem@davemloft.net \
--cc=jacob.e.keller@intel.com \
--cc=jogreene@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=nhorman@redhat.com \
--cc=sassmann@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).