* [PATCH net] ravb: Remove clear unhandled interrupt
@ 2015-12-06 11:42 Yoshihiro Kaneko
2015-12-06 19:18 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Yoshihiro Kaneko @ 2015-12-06 11:42 UTC (permalink / raw)
To: netdev; +Cc: David S. Miller, Simon Horman, Magnus Damm, linux-sh
From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
AVB-DMAC Reception Warning interrupt is not enabled, so it is not
necessary to clear the interrupt.
Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---
This patch is based on the master branch of David Miller's networking
tree.
drivers/net/ethernet/renesas/ravb_main.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/ethernet/renesas/ravb_main.c b/drivers/net/ethernet/renesas/ravb_main.c
index ed5da4d..b8fd5a5 100644
--- a/drivers/net/ethernet/renesas/ravb_main.c
+++ b/drivers/net/ethernet/renesas/ravb_main.c
@@ -1471,7 +1471,6 @@ static int ravb_close(struct net_device *ndev)
/* Disable interrupts by clearing the interrupt masks. */
ravb_write(ndev, 0, RIC0);
- ravb_write(ndev, 0, RIC1);
ravb_write(ndev, 0, RIC2);
ravb_write(ndev, 0, TIC);
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH net] ravb: Remove clear unhandled interrupt
2015-12-06 11:42 [PATCH net] ravb: Remove clear unhandled interrupt Yoshihiro Kaneko
@ 2015-12-06 19:18 ` Sergei Shtylyov
2015-12-07 16:59 ` Yoshihiro Kaneko
0 siblings, 1 reply; 4+ messages in thread
From: Sergei Shtylyov @ 2015-12-06 19:18 UTC (permalink / raw)
To: Yoshihiro Kaneko, netdev
Cc: David S. Miller, Simon Horman, Magnus Damm, linux-sh
Hello.
On 12/06/2015 02:42 PM, Yoshihiro Kaneko wrote:
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> AVB-DMAC Reception Warning interrupt is not enabled, so it is not
> necessary to clear the interrupt.
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
In principle I agree but perhaps we should clear RIC1 in probe() to not
depend on a state left from a bootloader?
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net] ravb: Remove clear unhandled interrupt
2015-12-06 19:18 ` Sergei Shtylyov
@ 2015-12-07 16:59 ` Yoshihiro Kaneko
2015-12-07 17:44 ` Sergei Shtylyov
0 siblings, 1 reply; 4+ messages in thread
From: Yoshihiro Kaneko @ 2015-12-07 16:59 UTC (permalink / raw)
To: Sergei Shtylyov
Cc: netdev, David S. Miller, Simon Horman, Magnus Damm, Linux-sh list
Hello,
2015-12-07 4:18 GMT+09:00 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>:
> Hello.
>
> On 12/06/2015 02:42 PM, Yoshihiro Kaneko wrote:
>
>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>
>> AVB-DMAC Reception Warning interrupt is not enabled, so it is not
>> necessary to clear the interrupt.
>>
>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>
>
> In principle I agree but perhaps we should clear RIC1 in probe() to not
> depend on a state left from a bootloader?
I think that it is a good idea.
I'll add it to v2.
>
> MBR, Sergei
>
Thanks,
Kaneko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH net] ravb: Remove clear unhandled interrupt
2015-12-07 16:59 ` Yoshihiro Kaneko
@ 2015-12-07 17:44 ` Sergei Shtylyov
0 siblings, 0 replies; 4+ messages in thread
From: Sergei Shtylyov @ 2015-12-07 17:44 UTC (permalink / raw)
To: Yoshihiro Kaneko
Cc: netdev, David S. Miller, Simon Horman, Magnus Damm, Linux-sh list
Hello.
On 12/07/2015 07:59 PM, Yoshihiro Kaneko wrote:
>>> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>>
>>> AVB-DMAC Reception Warning interrupt is not enabled, so it is not
>>> necessary to clear the interrupt.
>>>
>>> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>>
>>
>> In principle I agree but perhaps we should clear RIC1 in probe() to not
>> depend on a state left from a bootloader?
>
> I think that it is a good idea.
> I'll add it to v2.
Perhaps the ndo_open() method would be a better place...
>> MBR, Sergei
> Thanks,
> Kaneko
MBR, Sergei
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-07 17:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-06 11:42 [PATCH net] ravb: Remove clear unhandled interrupt Yoshihiro Kaneko
2015-12-06 19:18 ` Sergei Shtylyov
2015-12-07 16:59 ` Yoshihiro Kaneko
2015-12-07 17:44 ` Sergei Shtylyov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).