From: Ursula Braun <ubraun@linux.vnet.ibm.com>
To: davem@davemloft.net, mschwid2@linux.vnet.ibm.com,
heicars2@linux.vnet.ibm.com, netdev@vger.kernel.org,
linux-s390@vger.kernel.org
Cc: ubraunu@linux.vnet.ibm.com
Subject: [PATCH 1/7] iucv: prevent information leak in iucv_message
Date: Fri, 11 Dec 2015 11:38:51 +0100 [thread overview]
Message-ID: <1449830337-26091-2-git-send-email-ubraun@linux.vnet.ibm.com> (raw)
In-Reply-To: <1449830337-26091-1-git-send-email-ubraun@linux.vnet.ibm.com>
From: Eugene Crosser <Eugene.Crosser@ru.ibm.com>
Initialize storage for the future IUCV header that will be included
in the transmitted packet. Some of the header fields are unused with
HiperSockets transport, and will contain data left from some other
functions.
Signed-off-by: Eugene Crosser <Eugene.Crosser@ru.ibm.com>
Signed-off-by: Ursula Braun <ubraun@linux.vnet.ibm.com>
Reviewed-by: Thomas Richter <tmricht@linux.vnet.ibm.com>
---
net/iucv/af_iucv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/iucv/af_iucv.c b/net/iucv/af_iucv.c
index 3ea4c98..5bc473b 100644
--- a/net/iucv/af_iucv.c
+++ b/net/iucv/af_iucv.c
@@ -1031,7 +1031,7 @@ static int iucv_sock_sendmsg(struct socket *sock, struct msghdr *msg,
struct sock *sk = sock->sk;
struct iucv_sock *iucv = iucv_sk(sk);
struct sk_buff *skb;
- struct iucv_message txmsg;
+ struct iucv_message txmsg = {0};
struct cmsghdr *cmsg;
int cmsg_done;
long timeo;
--
2.3.9
next prev parent reply other threads:[~2015-12-11 10:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-11 10:38 [PATCH net-next 0/7] s390 network patches Ursula Braun
2015-12-11 10:38 ` Ursula Braun [this message]
2015-12-11 10:38 ` [PATCH 2/7] iucv: call skb_linearize() when needed Ursula Braun
2015-12-11 10:38 ` [PATCH 3/7] switch to alternate IBM mail address Ursula Braun
2015-12-11 10:38 ` [PATCH 4/7] s390-ctcm: Delete unnecessary checks before the function call "channel_remove" Ursula Braun
2015-12-11 10:38 ` [PATCH 5/7] qeth: initialize net_device with carrier off Ursula Braun
2015-12-11 10:38 ` [PATCH 6/7] qeth: repair SBAL elements calculation Ursula Braun
2015-12-11 10:38 ` [PATCH 7/7] qeth: get rid of redundant 0-termination Ursula Braun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1449830337-26091-2-git-send-email-ubraun@linux.vnet.ibm.com \
--to=ubraun@linux.vnet.ibm.com \
--cc=davem@davemloft.net \
--cc=heicars2@linux.vnet.ibm.com \
--cc=linux-s390@vger.kernel.org \
--cc=mschwid2@linux.vnet.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=ubraunu@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).