From: Przemek Kitszel <przemyslaw.kitszel@intel.com>
To: "Temerkhanov, Sergey" <sergey.temerkhanov@intel.com>,
Jiri Pirko <jiri@resnulli.us>
Cc: "intel-wired-lan@lists.osuosl.org"
<intel-wired-lan@lists.osuosl.org>,
"Nguyen, Anthony L" <anthony.l.nguyen@intel.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"Keller, Jacob E" <jacob.e.keller@intel.com>,
"Jakub Kicinski" <kuba@kernel.org>,
"Loktionov, Aleksandr" <aleksandr.loktionov@intel.com>,
"Kolacinski, Karol" <karol.kolacinski@intel.com>,
"Nitka, Grzegorz" <grzegorz.nitka@intel.com>,
"Schmidt, Michal" <mschmidt@redhat.com>
Subject: Re: [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index
Date: Mon, 10 Mar 2025 09:40:16 +0100 [thread overview]
Message-ID: <144fbab5-0cd6-478a-9500-838cd6303a73@intel.com> (raw)
In-Reply-To: <MW3PR11MB4681A62C71659C430281A15680D52@MW3PR11MB4681.namprd11.prod.outlook.com>
> Subject: Re: [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index
regarding -net vs -next, no one have complained that this bug hurts
>> + return (unsigned long)pci_get_dsn(pdev);
>
>> How do you ensure there is no xarray index collision then you cut the number like this?
The reduction occurs only on "32b" systems, which are unlikely to have
this device. And any mixing of the upper and lower 4B part still could
collide.
>
> It is also probably necessary to check if all devices supported by the driver have DSN capability enabled.
I will double check on the SoC you have in mind.
>
> Regards,
> Sergey
next prev parent reply other threads:[~2025-03-10 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-06 21:11 [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index Przemek Kitszel
2025-03-06 23:53 ` Jacob Keller
2025-03-07 12:40 ` Jiri Pirko
2025-03-07 23:21 ` Jacob Keller
2025-03-10 9:50 ` Przemek Kitszel
2025-03-07 12:39 ` Jiri Pirko
2025-03-07 13:42 ` Temerkhanov, Sergey
2025-03-10 8:40 ` Przemek Kitszel [this message]
2025-03-10 12:23 ` Jiri Pirko
2025-03-11 10:14 ` Przemek Kitszel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=144fbab5-0cd6-478a-9500-838cd6303a73@intel.com \
--to=przemyslaw.kitszel@intel.com \
--cc=aleksandr.loktionov@intel.com \
--cc=anthony.l.nguyen@intel.com \
--cc=grzegorz.nitka@intel.com \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@resnulli.us \
--cc=karol.kolacinski@intel.com \
--cc=kuba@kernel.org \
--cc=mschmidt@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=sergey.temerkhanov@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).