From: Paolo Abeni <pabeni@redhat.com>
To: Hannes Frederic Sowa <hannes@stressinduktion.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Pravin B Shelar <pshelar@nicira.com>,
Jiri Benc <jbenc@redhat.com>, Jesse Gross <jesse@nicira.com>
Subject: Re: [PATCH net] geneve: initialize needed_headroom
Date: Wed, 23 Dec 2015 16:39:36 +0100 [thread overview]
Message-ID: <1450885176.4301.36.camel@redhat.com> (raw)
In-Reply-To: <567ABF31.8080306@stressinduktion.org>
On Wed, 2015-12-23 at 16:35 +0100, Hannes Frederic Sowa wrote:
> On 23.12.2015 16:21, Paolo Abeni wrote:
> > @@ -1187,6 +1187,14 @@ static int geneve_configure(struct net *net, struct net_device *dev,
> > if (t)
> > return -EBUSY;
> >
> > + /* make enough headroom for basic scenario */
> > + encap_len = GENEVE_BASE_HLEN + ETH_HLEN;
> > + if (remote->sa.sa_family == AF_INET)
> > + encap_len += sizeof(struct iphdr);
> > + else
> > + encap_len += sizeof(struct ipv6hdr);
> > + dev->needed_headroom = encap_len;
> > +
>
> We are missing one time ETH_HLEN or hard_header_len of the lower_dev (if
> available) in here AFAIK.
You are right. Most probably performance numbers where good even with
the missing ETH_HLEN due to some rounding. I'll send a v2.
Paolo
prev parent reply other threads:[~2015-12-23 15:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 15:21 [PATCH net] geneve: initialize needed_headroom Paolo Abeni
2015-12-23 15:27 ` John W. Linville
2015-12-23 15:35 ` Hannes Frederic Sowa
2015-12-23 15:39 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1450885176.4301.36.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=hannes@stressinduktion.org \
--cc=jbenc@redhat.com \
--cc=jesse@nicira.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).