Re: [RESEND PATCH v1 0/4] Add support emac for the RK3036 SoC platform

Heiko Stübner
2015-12-29T22:27:55Z

Hi Dave,

Am Dienstag, 29. Dezember 2015, 15:53:14 schrieb David Miller:
> You have to submit this series properly, the same problem happend twice
> now.
>
> When you submit a series you should:
>
> 1) Make it clear which tree you expect these changes to be applied
> to. Here it is completely ambiguous, do you want it to go into
> my networking tree or some other subsystem tree?
>
> 2) You MUST keep all parties informed about all patches for a series
> like this. That means you cannot drop netdev from patch #4 as
> you did both times. Doing this aggravates the situation for
> #1 even more, because if a patch is not CC:'d to netdev it does
> not enter patchwork. And if it doesn't go into patchwork, I'm
> not looking at it.

I guess that is some unfortunate result of git send-email combined with
get_maintainer.pl . In general I also prefer to see the whole series, but have
gotten such partial series from other maintainers as well in the past, so it
seems to be depending on preferences somewhat.

For the series at hand, the 4th patch is the devicetree addition, which the
expected way is me picking it up, after you are comfortable with the code-
related changes.

Heiko