From: <zyjzyj2000@gmail.com>
To: <jeffrey.t.kirsher@intel.com>, <jesse.brandeburg@intel.com>,
<shannon.nelson@intel.com>, <carolyn.wyborny@intel.com>,
<donald.c.skidmore@intel.com>, <bruce.w.allan@intel.com>,
<john.ronciak@intel.com>, <mitch.a.williams@intel.com>,
<intel-wired-lan@lists.osuosl.org>, <netdev@vger.kernel.org>,
<e1000-devel@lists.sourceforge.net>, <mark.d.rustad@intel.com>
Cc: <venkat.viswanathan@windriver.com>,
<Boris.Shteinbock@windriver.com>, <Vincent.Bourg@windriver.com>
Subject: [PATCH 3/3] ixgbe: synchronize the link_speed and link_up of a slave interface
Date: Wed, 30 Dec 2015 17:16:35 +0800 [thread overview]
Message-ID: <1451466995-19015-4-git-send-email-zyjzyj2000@gmail.com> (raw)
In-Reply-To: <1451466995-19015-1-git-send-email-zyjzyj2000@gmail.com>
From: Zhu Yanjun <yanjun.zhu@windriver.com>
According to the suggestion from Rustad, Mark D, this behavior perhaps
is more related to the copper phy. But to make fiber phy more robust,
to all the interfaces as a slave interface, the link_speed and link_up
is synchronized.
Signed-off-by: Zhu Yanjun <yanjun.zhu@windriver.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
index 1bb6056..ce47639 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
@@ -6441,10 +6441,12 @@ static void ixgbe_watchdog_link_is_up(struct ixgbe_adapter *adapter)
* a bonding driver in 802.3ad mode. When X540 NIC acts as an
* independent interface, it is not necessary to synchronize link_up
* and link_speed.
- * In the end, not continue if (X540 NIC && SLAVE && link_speed UNKNOWN)
+ * According to the suggestion from Rustad, Mark D, this behavior
+ * perhaps is related to the copper phy. To make fiber phy more robust,
+ * To all the interfaces as a slave, the link_speed is checked.
+ * In the end, not continue if (SLAVE && link_speed UNKNOWN)
*/
- if ((hw->mac.type == ixgbe_mac_X540) &&
- (netdev->flags & IFF_SLAVE))
+ if (netdev->flags & IFF_SLAVE)
if (link_speed == IXGBE_LINK_SPEED_UNKNOWN)
return;
--
1.7.9.5
next prev parent reply other threads:[~2015-12-30 9:16 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-23 6:46 [PATCH 1/1] ixgbe: force to synchronize reporting "link on" and getting speed and duplex zyjzyj2000
2015-12-23 10:54 ` Jeff Kirsher
2015-12-24 3:12 ` [V2 PATCH 1/1] ixgbe: force to synchronize reporting "link on" and zyjzyj2000
2015-12-24 3:12 ` [PATCH 1/1] ixgbe: force to synchronize reporting "link on" and getting speed zyjzyj2000
2015-12-24 5:10 ` [V2 PATCH 1/1] ixgbe: force to synchronize reporting "link on" and zhuyj
2015-12-24 6:17 ` [Intel-wired-lan] " Tantilov, Emil S
2015-12-29 2:32 ` [PATCH V3] ixgbe: force to synchronize link_up and speed as a slave zyjzyj2000
2015-12-29 2:32 ` [PATCH 1/2] ixgbe: force to synchronize reporting "link on" and getting speed zyjzyj2000
2015-12-29 2:32 ` [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed zyjzyj2000
2015-12-29 16:18 ` [Intel-wired-lan] " Tantilov, Emil S
2015-12-29 19:17 ` Rustad, Mark D
2015-12-30 3:06 ` zhuyj
2015-12-30 9:16 ` [PATCH V4] ixgbe: synchronize the link_speed and link_up of a slave interface zyjzyj2000
2015-12-30 9:16 ` [PATCH 1/3] ixgbe: force to synchronize reporting "link on" and getting speed zyjzyj2000
2015-12-30 9:16 ` [PATCH 2/3] ixgbe: restrict synchronization of link_up and speed zyjzyj2000
2015-12-30 9:16 ` zyjzyj2000 [this message]
2015-12-30 19:02 ` [PATCH 3/3] ixgbe: synchronize the link_speed and link_up of a slave interface Rustad, Mark D
2015-12-31 5:04 ` [PATCH V5] ixgbe: synchronize link_up and link_speed of a slave zyjzyj2000
2015-12-31 5:04 ` [PATCH 1/1] ixgbe: synchronize link_up and link_speed of a slave interface zyjzyj2000
2015-12-31 5:37 ` Jeff Kirsher
2015-12-31 7:11 ` [PATCH V6] ixgbe: synchronize link_up and link_speed of a slave zyjzyj2000
2015-12-31 7:11 ` [PATCH V6 1/1] ixgbe: synchronize link_up and link_speed of a slave interface zyjzyj2000
2015-12-31 5:17 ` [PATCH V5] ixgbe: synchronize link_up and link_speed of a slave Jeff Kirsher
2015-12-31 5:24 ` zhuyj
2015-12-30 2:49 ` [Intel-wired-lan] [PATCH 2/2] ixgbe: restrict synchronization of link_up and speed zhuyj
2015-12-30 6:55 ` Tantilov, Emil S
2015-12-30 8:20 ` zhuyj
2015-12-30 16:37 ` Tantilov, Emil S
2016-01-06 5:41 ` zhuyj
2016-01-06 15:30 ` Tantilov, Emil S
2016-01-07 2:08 ` zhuyj
2016-01-07 2:38 ` zhuyj
2015-12-23 12:17 ` [PATCH 1/1] ixgbe: force to synchronize reporting "link on" and getting speed and duplex Sergei Shtylyov
2015-12-23 15:59 ` [Intel-wired-lan] " Tantilov, Emil S
2015-12-23 18:09 ` [E1000-devel] " Stephen Hemminger
2015-12-24 2:27 ` zhuyj
2015-12-24 5:58 ` Tantilov, Emil S
2015-12-24 6:24 ` zhuyj
2015-12-24 14:52 ` Tantilov, Emil S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451466995-19015-4-git-send-email-zyjzyj2000@gmail.com \
--to=zyjzyj2000@gmail.com \
--cc=Boris.Shteinbock@windriver.com \
--cc=Vincent.Bourg@windriver.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=john.ronciak@intel.com \
--cc=mark.d.rustad@intel.com \
--cc=mitch.a.williams@intel.com \
--cc=netdev@vger.kernel.org \
--cc=shannon.nelson@intel.com \
--cc=venkat.viswanathan@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).