From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next 1/5] sctp: add the rhashtable apis for sctp global transport hashtable Date: Wed, 30 Dec 2015 11:57:31 -0500 Message-ID: <1451494651.8255.22.camel@edumazet-glaptop2.roam.corp.google.com> References: <2c413161eb3a2c74453bd8dc11815af7e237515e.1451490447.git.lucien.xin@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Cc: network dev , linux-sctp@vger.kernel.org, mleitner@redhat.com, vyasevic@redhat.com, daniel@iogearbox.net, davem@davemloft.net To: Xin Long Return-path: Received: from mail-pa0-f42.google.com ([209.85.220.42]:35469 "EHLO mail-pa0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753360AbbL3Q5d (ORCPT ); Wed, 30 Dec 2015 11:57:33 -0500 In-Reply-To: <2c413161eb3a2c74453bd8dc11815af7e237515e.1451490447.git.lucien.xin@gmail.com> Sender: netdev-owner@vger.kernel.org List-ID: On Wed, 2015-12-30 at 23:50 +0800, Xin Long wrote: > tranport hashtbale will replace the association hashtable to do the > lookup for transport, and then get association by t->assoc, rhashtable > apis will be used because of it's resizable, scalable and using rcu. > > lport + rport + paddr will be the base hashkey to locate the chain, > with net to protect one netns from another, then plus the laddr to > compare to get the target. > > this patch will provider the lookup functions: > - sctp_epaddr_lookup_transport > - sctp_addrs_lookup_transport > > hash/unhash functions: > - sctp_hash_transport > - sctp_unhash_transport > > init/destroy functions: > - sctp_transport_hashtable_init > - sctp_transport_hashtable_destroy > > Signed-off-by: Xin Long > Signed-off-by: Marcelo Ricardo Leitner > --- I am against using rhashtable in SCTP (or TCP) at this stage, given the number of bugs we have with it.