* [PATCH net-next] ixgbe: Extend trust to allow guest to set unicast address
@ 2015-12-31 11:12 Chas Williams
2016-01-01 0:03 ` Jeff Kirsher
0 siblings, 1 reply; 5+ messages in thread
From: Chas Williams @ 2015-12-31 11:12 UTC (permalink / raw)
To: davem; +Cc: netdev, Chas Williams
When running certain routing protocols like VRRP, VF guests need the
ability to set the unicast address of the interface. Extend the new ndo
trust feature to let the hypervisor trust a guest to set/update its own
unicast address.
Signed-off-by: Chas Williams <3chas3@gmail.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index eeff3d0..63cff17 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -887,7 +887,7 @@ static int ixgbe_set_vf_mac_addr(struct ixgbe_adapter *adapter,
return -1;
}
- if (adapter->vfinfo[vf].pf_set_mac &&
+ if (adapter->vfinfo[vf].pf_set_mac && !adapter->vfinfo[vf].trusted &&
!ether_addr_equal(adapter->vfinfo[vf].vf_mac_addresses, new_mac)) {
e_warn(drv,
"VF %d attempted to override administratively set MAC address\n"
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH net-next] ixgbe: Extend trust to allow guest to set unicast address
2015-12-31 11:12 Chas Williams
@ 2016-01-01 0:03 ` Jeff Kirsher
0 siblings, 0 replies; 5+ messages in thread
From: Jeff Kirsher @ 2016-01-01 0:03 UTC (permalink / raw)
To: Chas Williams; +Cc: David Miller, netdev
On Thu, Dec 31, 2015 at 3:12 AM, Chas Williams <3chas3@gmail.com> wrote:
> When running certain routing protocols like VRRP, VF guests need the
> ability to set the unicast address of the interface. Extend the new ndo
> trust feature to let the hypervisor trust a guest to set/update its own
> unicast address.
>
> Signed-off-by: Chas Williams <3chas3@gmail.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Please send this to intel-wired-lan@lists.osuosl.org mailing list, or
at least CC the list since all Wired Ethernet Intel driver patches are
handled through that list.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH net-next] ixgbe: Extend trust to allow guest to set unicast address
@ 2016-01-01 17:34 Chas Williams
2016-01-13 19:00 ` [Intel-wired-lan] " Schmitt, Phillip J
0 siblings, 1 reply; 5+ messages in thread
From: Chas Williams @ 2016-01-01 17:34 UTC (permalink / raw)
To: intel-wired-lan; +Cc: netdev, Chas Williams
When running certain routing protocols like VRRP, VF guests need the
ability to set the unicast address of the interface. Extend the new ndo
trust feature to let the hypervisor trust a guest to set/update its own
unicast address.
Signed-off-by: Chas Williams <3chas3@gmail.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index eeff3d0..63cff17 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -887,7 +887,7 @@ static int ixgbe_set_vf_mac_addr(struct ixgbe_adapter *adapter,
return -1;
}
- if (adapter->vfinfo[vf].pf_set_mac &&
+ if (adapter->vfinfo[vf].pf_set_mac && !adapter->vfinfo[vf].trusted &&
!ether_addr_equal(adapter->vfinfo[vf].vf_mac_addresses, new_mac)) {
e_warn(drv,
"VF %d attempted to override administratively set MAC address\n"
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH net-next] ixgbe: Extend trust to allow guest to set unicast address
@ 2016-01-05 22:30 Chas Williams
0 siblings, 0 replies; 5+ messages in thread
From: Chas Williams @ 2016-01-05 22:30 UTC (permalink / raw)
To: intel-wired-lan; +Cc: netdev, Chas Williams
When running certain routing protocols like VRRP, VF guests need the
ability to set the unicast address of the interface. Extend the new ndo
trust feature to let the hypervisor trust a guest to set/update its own
unicast address.
Signed-off-by: Chas Williams <3chas3@gmail.com>
---
drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
index eeff3d0..63cff17 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_sriov.c
@@ -887,7 +887,7 @@ static int ixgbe_set_vf_mac_addr(struct ixgbe_adapter *adapter,
return -1;
}
- if (adapter->vfinfo[vf].pf_set_mac &&
+ if (adapter->vfinfo[vf].pf_set_mac && !adapter->vfinfo[vf].trusted &&
!ether_addr_equal(adapter->vfinfo[vf].vf_mac_addresses, new_mac)) {
e_warn(drv,
"VF %d attempted to override administratively set MAC address\n"
--
2.5.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* RE: [Intel-wired-lan] [PATCH net-next] ixgbe: Extend trust to allow guest to set unicast address
2016-01-01 17:34 [PATCH net-next] ixgbe: Extend trust to allow guest to set unicast address Chas Williams
@ 2016-01-13 19:00 ` Schmitt, Phillip J
0 siblings, 0 replies; 5+ messages in thread
From: Schmitt, Phillip J @ 2016-01-13 19:00 UTC (permalink / raw)
To: Chas Williams, intel-wired-lan@lists.osuosl.org; +Cc: netdev@vger.kernel.org
> -----Original Message-----
> From: Intel-wired-lan [mailto:intel-wired-lan-bounces@lists.osuosl.org] On
> Behalf Of Chas Williams
> Sent: Friday, January 01, 2016 9:34 AM
> To: intel-wired-lan@lists.osuosl.org
> Cc: netdev@vger.kernel.org
> Subject: [Intel-wired-lan] [PATCH net-next] ixgbe: Extend trust to allow guest to
> set unicast address
>
> When running certain routing protocols like VRRP, VF guests need the ability to
> set the unicast address of the interface. Extend the new ndo trust feature to let
> the hypervisor trust a guest to set/update its own unicast address.
>
> Signed-off-by: Chas Williams <3chas3@gmail.com>
> ---
Tested-by: Phil Schmitt <phillip.j.schmitt@intel.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-01-13 19:00 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-01 17:34 [PATCH net-next] ixgbe: Extend trust to allow guest to set unicast address Chas Williams
2016-01-13 19:00 ` [Intel-wired-lan] " Schmitt, Phillip J
-- strict thread matches above, loose matches on Subject: below --
2016-01-05 22:30 Chas Williams
2015-12-31 11:12 Chas Williams
2016-01-01 0:03 ` Jeff Kirsher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).