From: Andreas Henriksson <andreas@fatal.se>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: netdev@vger.kernel.org, Andreas Henriksson <andreas@fatal.se>
Subject: [PATCH iproute2 v2 1/2] arpd: drop unnecessary explicit null termination
Date: Sun, 3 Jan 2016 19:39:32 +0100 [thread overview]
Message-ID: <1451846374-2665-1-git-send-email-andreas@fatal.se> (raw)
In-Reply-To: <20160103090404.054e724b@xeon-e3>
This is a followup to a previous commit 61170fd88d264c
"get rid of unnecessary fgets() buffer size limitation".
If fgets guarantees buffer will be null terminated in the
given size, then we can also drop the explicit termination.
Signed-off-by: Andreas Henriksson <andreas@fatal.se>
---
misc/arpd.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/misc/arpd.c b/misc/arpd.c
index 6bb9bd1..700dc50 100644
--- a/misc/arpd.c
+++ b/misc/arpd.c
@@ -702,7 +702,6 @@ int main(int argc, char **argv)
goto do_abort;
}
- buf[sizeof(buf)-1] = 0;
while (fgets(buf, sizeof(buf), fp)) {
__u8 b1[6];
char ipbuf[128];
--
2.1.4
next prev parent reply other threads:[~2016-01-03 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-03 16:09 [PATCH iproute2] arpd: drop unnecessary explicit null termination Andreas Henriksson
2016-01-03 17:04 ` Stephen Hemminger
2016-01-03 18:39 ` Andreas Henriksson [this message]
2016-01-03 18:39 ` [PATCH iproute2 v2 2/2] arpd: fix parsing of unlikely long comments Andreas Henriksson
2016-01-03 18:44 ` Andreas Henriksson
2016-01-03 23:04 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1451846374-2665-1-git-send-email-andreas@fatal.se \
--to=andreas@fatal.se \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).