From: Sudip Mukherjee <sudipm.mukherjee@gmail.com>
To: "David S. Miller" <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org,
adi-buildroot-devel@lists.sourceforge.net,
netdev@vger.kernel.org,
Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH 2/2] bfin_mac: fix error path
Date: Fri, 8 Jan 2016 16:58:15 +0530 [thread overview]
Message-ID: <1452252495-20961-2-git-send-email-sudipm.mukherjee@gmail.com> (raw)
In-Reply-To: <1452252495-20961-1-git-send-email-sudipm.mukherjee@gmail.com>
While building blackfin defconfig we were getting a build warning:
warning: label 'out_err_irq_alloc' defined but not used.
Commit e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
removed the label out_err_mdiobus_register but then mistakenly jumped to
out_err_alloc. But it was actually supposed to jump to out_err_irq_alloc.
Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/net/ethernet/adi/bfin_mac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c
index 6f3432a..5ddfd0e 100644
--- a/drivers/net/ethernet/adi/bfin_mac.c
+++ b/drivers/net/ethernet/adi/bfin_mac.c
@@ -1857,7 +1857,7 @@ static int bfin_mii_bus_probe(struct platform_device *pdev)
rc = mdiobus_register(miibus);
if (rc) {
dev_err(&pdev->dev, "Cannot register MDIO bus!\n");
- goto out_err_alloc;
+ goto out_err_irq_alloc;
}
platform_set_drvdata(pdev, miibus);
--
1.9.1
next prev parent reply other threads:[~2016-01-08 11:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 11:28 [PATCH 1/2] phy: fix blackfin build failure Sudip Mukherjee
2016-01-08 11:28 ` Sudip Mukherjee [this message]
2016-01-11 3:46 ` [PATCH 2/2] bfin_mac: fix error path David Miller
2016-01-08 15:57 ` [PATCH 1/2] phy: fix blackfin build failure Andrew Lunn
2016-01-11 3:46 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452252495-20961-2-git-send-email-sudipm.mukherjee@gmail.com \
--to=sudipm.mukherjee@gmail.com \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).