From: Guenter Roeck <linux@roeck-us.net>
To: "David S. Miller" <davem@davemloft.net>
Cc: adi-buildroot-devel@lists.sourceforge.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Guenter Roeck <linux@roeck-us.net>, Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function
Date: Sat, 9 Jan 2016 08:37:06 -0800 [thread overview]
Message-ID: <1452357427-30578-1-git-send-email-linux@roeck-us.net> (raw)
Commit e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
removed interrupt allocation code. While doing so, error handling got
messed up a bit, resulting in the following build warning and a missed
call to mdiobus_free() in the probe function error path.
drivers/net/ethernet/adi/bfin_mac.c: In function 'bfin_mii_bus_probe':
drivers/net/ethernet/adi/bfin_mac.c:1865:1: warning:
label 'out_err_irq_alloc' defined but not used
Fixes: e7f4dc3536a4 ("mdio: Move allocation of interrupts into core")
Cc: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
---
drivers/net/ethernet/adi/bfin_mac.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/adi/bfin_mac.c b/drivers/net/ethernet/adi/bfin_mac.c
index 62862744c870..8c5132624510 100644
--- a/drivers/net/ethernet/adi/bfin_mac.c
+++ b/drivers/net/ethernet/adi/bfin_mac.c
@@ -1856,13 +1856,13 @@ static int bfin_mii_bus_probe(struct platform_device *pdev)
rc = mdiobus_register(miibus);
if (rc) {
dev_err(&pdev->dev, "Cannot register MDIO bus!\n");
- goto out_err_alloc;
+ goto out_err_mdiobus_register;
}
platform_set_drvdata(pdev, miibus);
return 0;
-out_err_irq_alloc:
+out_err_mdiobus_register:
mdiobus_free(miibus);
out_err_alloc:
peripheral_free_list(pin_req);
--
2.1.4
next reply other threads:[~2016-01-09 16:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-09 16:37 Guenter Roeck [this message]
2016-01-09 16:37 ` [PATCH -next 2/2] net: bfin_mac: Fix build error due to missed API change Guenter Roeck
2016-01-09 16:58 ` [PATCH -next 1/2] net: bfin_mac: Fix error handling in probe function Andrew Lunn
2016-01-09 18:10 ` Guenter Roeck
2016-01-09 20:52 ` Andrew Lunn
2016-01-10 15:16 ` Guenter Roeck
2016-01-10 15:49 ` Andrew Lunn
2016-01-10 16:22 ` Guenter Roeck
2016-01-10 17:21 ` Andrew Lunn
2016-01-10 20:10 ` Guenter Roeck
2016-01-10 23:58 ` Andrew Lunn
2016-01-11 8:43 ` Sudip Mukherjee
2016-01-11 16:23 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452357427-30578-1-git-send-email-linux@roeck-us.net \
--to=linux@roeck-us.net \
--cc=adi-buildroot-devel@lists.sourceforge.net \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).