From: Baozeng Ding <sploving1@gmail.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, Baozeng Ding <sploving1@gmail.com>
Subject: [PATCH v3] netlink: fix null pointer dereference on nlk->groups
Date: Tue, 12 Jan 2016 19:10:43 +0800 [thread overview]
Message-ID: <1452597043-4298-1-git-send-email-sploving1@gmail.com> (raw)
In-Reply-To: <1452231970-27357-1-git-send-email-sploving1@gmail.com>
If groups is not 0 and nlk->groups is NULL, it will not return
immediately and cause a null pointer dereference later.
Signed-off-by: Baozeng Ding <sploving1@gmail.com>
---
The v3 version adds WARN_ON, suggested by David Miller. Thanks for
David's feedback.
---
net/netlink/af_netlink.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/net/netlink/af_netlink.c b/net/netlink/af_netlink.c
index 59651af..f93d579 100644
--- a/net/netlink/af_netlink.c
+++ b/net/netlink/af_netlink.c
@@ -1576,7 +1576,10 @@ static int netlink_bind(struct socket *sock, struct sockaddr *addr,
}
}
- if (!groups && (nlk->groups == NULL || !(u32)nlk->groups[0]))
+ if (WARN_ON(!nlk->groups))
+ return 0;
+
+ if (!groups && !(u32)nlk->groups[0])
return 0;
netlink_table_grab();
--
1.9.1
next prev parent reply other threads:[~2016-01-12 11:12 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-08 5:46 [PATCH] netlink: fix null pointer dereference on nlk->groups Baozeng Ding
2016-01-08 19:43 ` Sergei Shtylyov
2016-01-09 15:56 ` [PATCH v2] " Baozeng Ding
2016-01-11 4:27 ` David Miller
2016-01-12 11:10 ` Baozeng Ding [this message]
2016-01-12 11:15 ` [PATCH v3] " Denis Kirjanov
2016-01-12 12:00 ` Herbert Xu
2016-01-12 19:40 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452597043-4298-1-git-send-email-sploving1@gmail.com \
--to=sploving1@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).