From: Neil Horman <nhorman@tuxdriver.com>
To: netdev@vger.kernel.org
Cc: Neil Horman <nhorman@tuxdriver.com>,
"David S. Miller" <davem@davemloft.net>,
Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
Subject: [PATCH 1/2] 3c59x: balance page maps and unmaps
Date: Wed, 13 Jan 2016 12:43:53 -0500 [thread overview]
Message-ID: <1452707034-16379-2-git-send-email-nhorman@tuxdriver.com> (raw)
In-Reply-To: <1452707034-16379-1-git-send-email-nhorman@tuxdriver.com>
debug kernel noticed a screw up in 3c59x. skbs being mapped as page were being
unmapped as singles. Easy fix. Tested by myself
Signed-off-by: Neil Horman <nhorman@tuxdriver.com
CC: "David S. Miller" <davem@davemloft.net>
CC: Steffen Klassert <klassert@mathematik.tu-chemnitz.de>
---
drivers/net/ethernet/3com/3c59x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/3com/3c59x.c b/drivers/net/ethernet/3com/3c59x.c
index 2839af0..eec4a3a 100644
--- a/drivers/net/ethernet/3com/3c59x.c
+++ b/drivers/net/ethernet/3com/3c59x.c
@@ -2460,7 +2460,7 @@ boomerang_interrupt(int irq, void *dev_id)
#if DO_ZEROCOPY
int i;
for (i=0; i<=skb_shinfo(skb)->nr_frags; i++)
- pci_unmap_single(VORTEX_PCI(vp),
+ pci_unmap_page(VORTEX_PCI(vp),
le32_to_cpu(vp->tx_ring[entry].frag[i].addr),
le32_to_cpu(vp->tx_ring[entry].frag[i].length)&0xFFF,
PCI_DMA_TODEVICE);
--
2.5.0
next prev parent reply other threads:[~2016-01-13 17:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-13 17:43 [PATCH 0/2] 3c59x: Fix dma map/unmap imbalances Neil Horman
2016-01-13 17:43 ` Neil Horman [this message]
2016-01-13 17:43 ` [PATCH 2/2] 3c59x: fix another page map/single unmap imbalance Neil Horman
2016-01-13 19:55 ` [PATCH 0/2] 3c59x: Fix dma map/unmap imbalances David Miller
2016-01-13 20:12 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452707034-16379-2-git-send-email-nhorman@tuxdriver.com \
--to=nhorman@tuxdriver.com \
--cc=davem@davemloft.net \
--cc=klassert@mathematik.tu-chemnitz.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).