* [PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts
@ 2016-01-17 10:30 Geert Uytterhoeven
2016-01-17 17:02 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2016-01-17 10:30 UTC (permalink / raw)
To: David S. Miller, netdev, linux-kernel; +Cc: Geert Uytterhoeven
In file included from net/ipv4/tcp_ipv4.c:77 (and many more):
include/net/tcp_memcontrol.h:5: warning: ‘struct cgroup_subsys’ declared inside parameter list
include/net/tcp_memcontrol.h:5: warning: its scope is only this definition or declaration, which is probably not what you want
Add forward declarations for all used structures to fix this.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
include/net/tcp_memcontrol.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/include/net/tcp_memcontrol.h b/include/net/tcp_memcontrol.h
index 3a17b16ae8aa47c4..01ff7c6efada9797 100644
--- a/include/net/tcp_memcontrol.h
+++ b/include/net/tcp_memcontrol.h
@@ -1,6 +1,9 @@
#ifndef _TCP_MEMCG_H
#define _TCP_MEMCG_H
+struct cgroup_subsys;
+struct mem_cgroup;
+
int tcp_init_cgroup(struct mem_cgroup *memcg, struct cgroup_subsys *ss);
void tcp_destroy_cgroup(struct mem_cgroup *memcg);
#endif /* _TCP_MEMCG_H */
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts
2016-01-17 10:30 [PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts Geert Uytterhoeven
@ 2016-01-17 17:02 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2016-01-17 17:02 UTC (permalink / raw)
To: geert; +Cc: netdev, linux-kernel
From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Sun, 17 Jan 2016 11:30:37 +0100
> In file included from net/ipv4/tcp_ipv4.c:77 (and many more):
> include/net/tcp_memcontrol.h:5: warning: ‘struct cgroup_subsys’ declared inside parameter list
> include/net/tcp_memcontrol.h:5: warning: its scope is only this definition or declaration, which is probably not what you want
>
> Add forward declarations for all used structures to fix this.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied, thanks Geert.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-01-17 17:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-17 10:30 [PATCH] tcp_memcontrol: Forward declare cgroup_subsys and mem_cgroup stucts Geert Uytterhoeven
2016-01-17 17:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox