netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Florian Fainelli <f.fainelli@gmail.com>
To: netdev@vger.kernel.org
Cc: davem@davemloft.net, andrew@lunn.ch,
	sergei.shtylyov@cogentembedded.com, Woojung.Huh@microchip.com,
	Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH net 3/3] net: bcmgenet: Properly configure PHY to ignore interrupt
Date: Mon, 18 Jan 2016 19:33:08 -0800	[thread overview]
Message-ID: <1453174388-26752-4-git-send-email-f.fainelli@gmail.com> (raw)
In-Reply-To: <1453174388-26752-1-git-send-email-f.fainelli@gmail.com>

By the time we execute bcmgenet_mii_probe(), the MDIO bus structure has
long been allocated and registered. Overirring the PHY interrupt using
the MDIO bus structure has no chance to work anymore, because
of_mdiobus_register() has call phy_device_create() for use, which copied
the MDIO bus address's irq for the PHY into the PHY device "irq" member.

Since we do have a proper reference to a PHY device in
bcmgenet_mii_probe(), just assign the desired IRQ value here.

Fixes: aa09677cba42 ("net: bcmgenet: add MDIO routines")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
 drivers/net/ethernet/broadcom/genet/bcmmii.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/broadcom/genet/bcmmii.c b/drivers/net/ethernet/broadcom/genet/bcmmii.c
index 0d775964b060..457c3bc8cfff 100644
--- a/drivers/net/ethernet/broadcom/genet/bcmmii.c
+++ b/drivers/net/ethernet/broadcom/genet/bcmmii.c
@@ -401,7 +401,7 @@ int bcmgenet_mii_probe(struct net_device *dev)
 	 * Ethernet MAC ISRs
 	 */
 	if (priv->internal_phy)
-		priv->mii_bus->irq[phydev->mdio.addr] = PHY_IGNORE_INTERRUPT;
+		priv->phydev->irq = PHY_IGNORE_INTERRUPT;
 
 	return 0;
 }
-- 
2.1.0

  parent reply	other threads:[~2016-01-19  3:33 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19  3:33 [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS Florian Fainelli
2016-01-19  3:33 ` [PATCH net 1/3] net: phy: Avoid polling PHY with PHY_IGNORE_INTERRUPTS Florian Fainelli
2016-01-19  3:33 ` [PATCH net 2/3] net: phy: Fix phy_mac_interrupt() Florian Fainelli
2016-01-19  3:33 ` Florian Fainelli [this message]
2016-01-19 19:33 ` [PATCH net 0/3] net: phy: Finally fix PHY_IGNORE_INTERRUPTS David Miller
2016-01-20 21:20   ` Woojung.Huh
2016-01-20 21:29     ` Florian Fainelli
2016-01-20 22:20       ` Woojung.Huh
2016-01-21  0:59       ` Woojung.Huh
2016-01-21  2:58         ` David Miller
2016-01-21  6:32           ` Florian Fainelli
2016-01-21 18:49             ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453174388-26752-4-git-send-email-f.fainelli@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=Woojung.Huh@microchip.com \
    --cc=andrew@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).