From: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>,
intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org
Cc: Andrew Vagin <avagin@parallels.com>,
Konstantin Khorenko <khorenko@virtuozzo.com>,
devel@openvz.org
Subject: Re: [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields
Date: Wed, 20 Jan 2016 19:32:19 -0800 [thread overview]
Message-ID: <1453347139.3312.2.camel@intel.com> (raw)
In-Reply-To: <1453277324-6180-1-git-send-email-ptikhomirov@virtuozzo.com>
[-- Attachment #1: Type: text/plain, Size: 810 bytes --]
On Wed, 2016-01-20 at 11:08 +0300, Pavel Tikhomirov wrote:
> It seem to be non intentionaly changed to tx in
> commit adc810900a70 ("ixgbe: Refactor busy poll socket code to
> address
> multiple issues")
>
> Lock is taken from ixgbe_low_latency_recv, and there under this
> lock we use ixgbe_clean_rx_irq so it looks wrong for me to increment
> tx counter.
>
> Yield stats can be shown through ethtool:
> ethtool -S enp129s0 | grep yield
>
> v2: follow commit citing style
>
> Signed-off-by: Pavel Tikhomirov <ptikhomirov@virtuozzo.com>
> ---
> drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Why are you re-sending this patch? I already have it queued up for
testing in my tree. This just causes problems and extra work for me.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
prev parent reply other threads:[~2016-01-21 3:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-20 8:08 [PATCH RESEND v2] ixgbe: on recv increment rx.ring->stats.yields Pavel Tikhomirov
2016-01-21 3:32 ` Jeff Kirsher [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1453347139.3312.2.camel@intel.com \
--to=jeffrey.t.kirsher@intel.com \
--cc=avagin@parallels.com \
--cc=devel@openvz.org \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=khorenko@virtuozzo.com \
--cc=netdev@vger.kernel.org \
--cc=ptikhomirov@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).