* [PATCH] ptp: ixp46x: use helpers for converting ns to timespec
@ 2016-01-28 2:27 Kefeng Wang
2016-01-28 9:47 ` Richard Cochran
2016-01-29 20:39 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Kefeng Wang @ 2016-01-28 2:27 UTC (permalink / raw)
To: David S . Miller
Cc: Richard Cochran, guohanjun, netdev, linux-kernel, Kefeng Wang
Convert the driver to use ns_to_timespec64() and timespec64_to_ns()
instead of open coding the same logic.
Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
---
drivers/ptp/ptp_ixp46x.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/drivers/ptp/ptp_ixp46x.c b/drivers/ptp/ptp_ixp46x.c
index 934c139..ee4f183 100644
--- a/drivers/ptp/ptp_ixp46x.c
+++ b/drivers/ptp/ptp_ixp46x.c
@@ -178,7 +178,6 @@ static int ptp_ixp_adjtime(struct ptp_clock_info *ptp, s64 delta)
static int ptp_ixp_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts)
{
u64 ns;
- u32 remainder;
unsigned long flags;
struct ixp_clock *ixp_clock = container_of(ptp, struct ixp_clock, caps);
struct ixp46x_ts_regs *regs = ixp_clock->regs;
@@ -189,8 +188,7 @@ static int ptp_ixp_gettime(struct ptp_clock_info *ptp, struct timespec64 *ts)
spin_unlock_irqrestore(®ister_lock, flags);
- ts->tv_sec = div_u64_rem(ns, 1000000000, &remainder);
- ts->tv_nsec = remainder;
+ *ts = ns_to_timespec64(ns);
return 0;
}
@@ -202,8 +200,7 @@ static int ptp_ixp_settime(struct ptp_clock_info *ptp,
struct ixp_clock *ixp_clock = container_of(ptp, struct ixp_clock, caps);
struct ixp46x_ts_regs *regs = ixp_clock->regs;
- ns = ts->tv_sec * 1000000000ULL;
- ns += ts->tv_nsec;
+ ns = timespec64_to_ns(ts);
spin_lock_irqsave(®ister_lock, flags);
--
2.6.0.GIT
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ptp: ixp46x: use helpers for converting ns to timespec
2016-01-28 2:27 [PATCH] ptp: ixp46x: use helpers for converting ns to timespec Kefeng Wang
@ 2016-01-28 9:47 ` Richard Cochran
2016-01-29 20:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Richard Cochran @ 2016-01-28 9:47 UTC (permalink / raw)
To: Kefeng Wang; +Cc: David S . Miller, guohanjun, netdev, linux-kernel
On Thu, Jan 28, 2016 at 10:27:19AM +0800, Kefeng Wang wrote:
> Convert the driver to use ns_to_timespec64() and timespec64_to_ns()
> instead of open coding the same logic.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
> ---
> drivers/ptp/ptp_ixp46x.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
Acked-by: Richard Cochran <richardcochran@gmail.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ptp: ixp46x: use helpers for converting ns to timespec
2016-01-28 2:27 [PATCH] ptp: ixp46x: use helpers for converting ns to timespec Kefeng Wang
2016-01-28 9:47 ` Richard Cochran
@ 2016-01-29 20:39 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2016-01-29 20:39 UTC (permalink / raw)
To: wangkefeng.wang; +Cc: richardcochran, guohanjun, netdev, linux-kernel
From: Kefeng Wang <wangkefeng.wang@huawei.com>
Date: Thu, 28 Jan 2016 10:27:19 +0800
> Convert the driver to use ns_to_timespec64() and timespec64_to_ns()
> instead of open coding the same logic.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-01-29 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-28 2:27 [PATCH] ptp: ixp46x: use helpers for converting ns to timespec Kefeng Wang
2016-01-28 9:47 ` Richard Cochran
2016-01-29 20:39 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).