netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <zyjzyj2000@gmail.com>
To: <zyjzyj2000@gmail.com>, <emil.s.tantilov@intel.com>,
	<phillip.j.schmitt@intel.com>, <jeffrey.t.kirsher@intel.com>,
	<netdev@vger.kernel.org>, <e1000-devel@lists.sourceforge.net>,
	<Boris.Shteinbock@windriver.com>
Subject: ixgbe: get link speed as a slave nic unrelated with link
Date: Mon, 1 Feb 2016 15:27:54 +0800	[thread overview]
Message-ID: <1454311675-24676-1-git-send-email-zyjzyj2000@gmail.com> (raw)
In-Reply-To: <1452258030-63996-5-git-send-email-jeffrey.t.kirsher@intel.com>


Hi, Emil

Thanks for your patch.
After I applied your patch, the following are the feedback from my users.

"
Users had tested the latest patch that you provided and it is much improved now. However it’s still not good enough as the users are planning field deployment. Here are their findings:

So close, but not quite 100%. I did run over 2500 re-negotiations on one interface of a bonded pair and got the 0 MBps status total of three times. The longest run without single error was something like 1800 re-negotiations or so. So, this version seems to improve the situation immensely (the unpatched driver fails like 25% of the time), but there still seems to remain some tiny race somewhere.

So  it seems the failure occurs once every 600-900 connections.
"

I delved into the source code. And I found that maybe this time slice can result in this problem.

bonding                ixgbe 
  |                     |
  |                    carrier_on
  |                     |
  |    <----------------|
 link_up                |
  |                     |
  |                    carrier_off
  |                     |
 get_link_speed ------->|
  |                     |

Now bonding driver is link up while speed is link_speed_unknown because of link flap.

To an independent nic, it is meaningless to get link speed while carrier is off. But to a slave nic, maybe it is helpful, especially nic link flaps.

Maybe this patch can fix the above time slice.

Any reply is appreciated.

Best Regards!
Zhu Yanjun

  reply	other threads:[~2016-02-01  7:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 13:00 [net-next 0/8][pull request] 10GbE Intel Wired LAN Driver Updates 2016-01-08 Jeff Kirsher
2016-01-08 13:00 ` [net-next 1/8] ixgbe: Fill at least min credits to a TC credit refills Jeff Kirsher
2016-01-08 13:00 ` [net-next 2/8] ixgbe: use correct FCoE DDP max check Jeff Kirsher
2016-01-08 13:00 ` [net-next 3/8] ixgbe: fix broken PFC with X550 Jeff Kirsher
2016-01-08 13:00 ` [net-next 4/8] ixgbe: do not call check_link for ethtool in ixgbe_get_settings() Jeff Kirsher
2016-02-01  7:27   ` zyjzyj2000 [this message]
2016-02-01  7:27     ` [PATCH 1/1] ixgbe: get link speed as a slave nic unrelated with link up zyjzyj2000
2016-02-01 15:55       ` Tantilov, Emil S
2016-02-01 15:53     ` ixgbe: get link speed as a slave nic unrelated with link Tantilov, Emil S
2016-02-03 10:17       ` zhuyj
2016-01-08 13:00 ` [net-next 5/8] ixgbe: Correct handling of any outer UDP checksum setting Jeff Kirsher
2016-01-08 13:00 ` [net-next 6/8] ixgbe: Fix to get FDMI HBA attributes information with X550 Jeff Kirsher
2016-01-08 13:00 ` [net-next 7/8] ixgbe: Fix MDD events generated when FCoE+SRIOV are enabled Jeff Kirsher
2016-01-08 13:00 ` [net-next 8/8] ixgbe: Make ATR recognize IPv6 extended headers Jeff Kirsher
2016-01-08 18:49 ` [net-next 0/8][pull request] 10GbE Intel Wired LAN Driver Updates 2016-01-08 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454311675-24676-1-git-send-email-zyjzyj2000@gmail.com \
    --to=zyjzyj2000@gmail.com \
    --cc=Boris.Shteinbock@windriver.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=emil.s.tantilov@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=phillip.j.schmitt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).