netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: <zyjzyj2000@gmail.com>
To: <zyjzyj2000@gmail.com>, <emil.s.tantilov@intel.com>,
	<phillip.j.schmitt@intel.com>, <jeffrey.t.kirsher@intel.com>,
	<netdev@vger.kernel.org>, <e1000-devel@lists.sourceforge.net>,
	<Boris.Shteinbock@windriver.com>
Subject: [PATCH 1/1] ixgbe: get link speed as a slave nic unrelated with link up
Date: Mon, 1 Feb 2016 15:27:55 +0800	[thread overview]
Message-ID: <1454311675-24676-2-git-send-email-zyjzyj2000@gmail.com> (raw)
In-Reply-To: <1454311675-24676-1-git-send-email-zyjzyj2000@gmail.com>

From: Zhu Yanjun <zyjzyj2000@gmail.com>

The commit 0e4d422f5f72 ("ixgbe: do not call check_link for ethtool
in ixgbe_get_settings()") decreases the bonding failures. But the
following time slice still results in a bonding failure.

bonding                ixgbe
  |                     |
  |                    carrier_on
  |                     |
  |    <----------------|
 link_up                |
  |                     |
  |                    carrier_off
  |                     |
 get_link_speed ------->|
  |                     |

As such, the nic link speed can unconditionally be gotten as a
slave nic whether the link is up or not.

Signed-off-by: Zhu Yanjun <zyjzyj2000@gmail.com>
---
 drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
index bea96b3..53edf39 100644
--- a/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
+++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c
@@ -311,7 +311,7 @@ static int ixgbe_get_settings(struct net_device *netdev,
 		break;
 	}
 
-	if (netif_carrier_ok(netdev)) {
+	if (netif_carrier_ok(netdev) || (netdev->flags & IFF_SLAVE)) {
 		switch (adapter->link_speed) {
 		case IXGBE_LINK_SPEED_10GB_FULL:
 			ethtool_cmd_speed_set(ecmd, SPEED_10000);
-- 
1.7.9.5

  reply	other threads:[~2016-02-01  7:26 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-08 13:00 [net-next 0/8][pull request] 10GbE Intel Wired LAN Driver Updates 2016-01-08 Jeff Kirsher
2016-01-08 13:00 ` [net-next 1/8] ixgbe: Fill at least min credits to a TC credit refills Jeff Kirsher
2016-01-08 13:00 ` [net-next 2/8] ixgbe: use correct FCoE DDP max check Jeff Kirsher
2016-01-08 13:00 ` [net-next 3/8] ixgbe: fix broken PFC with X550 Jeff Kirsher
2016-01-08 13:00 ` [net-next 4/8] ixgbe: do not call check_link for ethtool in ixgbe_get_settings() Jeff Kirsher
2016-02-01  7:27   ` ixgbe: get link speed as a slave nic unrelated with link zyjzyj2000
2016-02-01  7:27     ` zyjzyj2000 [this message]
2016-02-01 15:55       ` [PATCH 1/1] ixgbe: get link speed as a slave nic unrelated with link up Tantilov, Emil S
2016-02-01 15:53     ` ixgbe: get link speed as a slave nic unrelated with link Tantilov, Emil S
2016-02-03 10:17       ` zhuyj
2016-01-08 13:00 ` [net-next 5/8] ixgbe: Correct handling of any outer UDP checksum setting Jeff Kirsher
2016-01-08 13:00 ` [net-next 6/8] ixgbe: Fix to get FDMI HBA attributes information with X550 Jeff Kirsher
2016-01-08 13:00 ` [net-next 7/8] ixgbe: Fix MDD events generated when FCoE+SRIOV are enabled Jeff Kirsher
2016-01-08 13:00 ` [net-next 8/8] ixgbe: Make ATR recognize IPv6 extended headers Jeff Kirsher
2016-01-08 18:49 ` [net-next 0/8][pull request] 10GbE Intel Wired LAN Driver Updates 2016-01-08 David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1454311675-24676-2-git-send-email-zyjzyj2000@gmail.com \
    --to=zyjzyj2000@gmail.com \
    --cc=Boris.Shteinbock@windriver.com \
    --cc=e1000-devel@lists.sourceforge.net \
    --cc=emil.s.tantilov@intel.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=phillip.j.schmitt@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).