From: Stefan Assmann <sassmann@kpanic.de>
To: intel-wired-lan@lists.osuosl.org
Cc: netdev@vger.kernel.org, davem@davemloft.net,
jeffrey.t.kirsher@intel.com, sassmann@kpanic.de
Subject: [PATCH net-next 0/6] net/intel: call ndo_stop() instead of dev_close() when running offline selftest
Date: Tue, 2 Feb 2016 11:13:42 +0100 [thread overview]
Message-ID: <1454408028-16986-1-git-send-email-sassmann@kpanic.de> (raw)
Calling dev_close() causes IFF_UP to be cleared which will remove the
interfaces routes and some addresses. That's probably not what the user
intended when running the offline selftest. Besides this does not happen
if the interface is brought down before the test, so the current
behaviour is inconsistent.
Instead call the net_device_ops ndo_stop function directly and avoid
touching IFF_UP at all.
Tested this with igb, e1000e, ixgbe and i40e. All drivers now are able to
resume operation without restoring the IP address, gateway or such.
Stefan Assmann (6):
i40e: call ndo_stop() instead of dev_close() when running offline
selftest
ixgbe: call ndo_stop() instead of dev_close() when running offline
selftest
ixgbevf: call ndo_stop() instead of dev_close() when running offline
selftest
igb: call ndo_stop() instead of dev_close() when running offline
selftest
e1000: call ndo_stop() instead of dev_close() when running offline
selftest
e1000e: call ndo_stop() instead of dev_close() when running offline
selftest
drivers/net/ethernet/intel/e1000/e1000.h | 2 ++
drivers/net/ethernet/intel/e1000/e1000_ethtool.c | 4 ++--
drivers/net/ethernet/intel/e1000/e1000_main.c | 8 ++++----
drivers/net/ethernet/intel/e1000e/e1000.h | 2 ++
drivers/net/ethernet/intel/e1000e/ethtool.c | 4 ++--
drivers/net/ethernet/intel/e1000e/netdev.c | 4 ++--
drivers/net/ethernet/intel/i40e/i40e.h | 2 +-
drivers/net/ethernet/intel/i40e/i40e_ethtool.c | 4 ++--
drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ----
drivers/net/ethernet/intel/igb/igb.h | 2 ++
drivers/net/ethernet/intel/igb/igb_ethtool.c | 4 ++--
drivers/net/ethernet/intel/igb/igb_main.c | 8 ++++----
drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 ++
drivers/net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 4 ++--
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 ++--
drivers/net/ethernet/intel/ixgbevf/ethtool.c | 4 ++--
drivers/net/ethernet/intel/ixgbevf/ixgbevf.h | 2 ++
drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 4 ++--
18 files changed, 37 insertions(+), 31 deletions(-)
--
2.5.0
next reply other threads:[~2016-02-02 10:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-02 10:13 Stefan Assmann [this message]
2016-02-02 10:13 ` [PATCH net-next 1/6] i40e: call ndo_stop() instead of dev_close() when running offline selftest Stefan Assmann
2016-02-02 10:13 ` [PATCH net-next 2/6] ixgbe: " Stefan Assmann
2016-02-02 10:13 ` [PATCH net-next 3/6] ixgbevf: " Stefan Assmann
2016-02-02 10:13 ` [PATCH net-next 4/6] igb: " Stefan Assmann
2016-02-02 10:13 ` [PATCH net-next 5/6] e1000: " Stefan Assmann
2016-02-02 10:13 ` [PATCH net-next 6/6] e1000e: " Stefan Assmann
2016-02-02 11:09 ` kbuild test robot
2016-02-02 12:59 ` Stefan Assmann
2016-02-02 21:28 ` David Miller
2016-02-03 8:13 ` Stefan Assmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454408028-16986-1-git-send-email-sassmann@kpanic.de \
--to=sassmann@kpanic.de \
--cc=davem@davemloft.net \
--cc=intel-wired-lan@lists.osuosl.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).