Re: [PATCH net-next v2] xen-netback: implement dynamic multicast control

[Ian Campbell <ian.campbell@citrix.com>]

On Tue, 2016-02-02 at 11:48 +0000, Paul Durrant wrote:
> > -----Original Message-----
> > From: Wei Liu [mailto:wei.liu2@citrix.com]
> > Sent: 02 February 2016 11:47
> > To: Paul Durrant
> > Cc: netdev@vger.kernel.org; xen-devel@lists.xenproject.org; Ian
> > Campbell;
> > Wei Liu
> > Subject: Re: [PATCH net-next v2] xen-netback: implement dynamic
> > multicast
> > control
> > 
> > On Tue, Feb 02, 2016 at 11:31:08AM +0000, Paul Durrant wrote:
> > [...]
> > > +static int xen_register_mcast_ctrl_watch(struct xenbus_device *dev,
> > > +					 struct xenvif *vif)
> > > +{
> > > +	int err = 0;
> > > +	char *node;
> > > +	unsigned maxlen = strlen(dev->otherend) +
> > > +		sizeof("/request-multicast-control");
> > > +
> > > +	if (vif->mcast_ctrl_watch.node)
> > > +		return -EADDRINUSE;
> > > +
> > 
> > Sorry if I didn't make myself clear enough. I think EADDRINUSE should
> > also be logged.
> > 
> 
> Ok. Not sure how much noise that will cause though.

If this is a guest trigerable path then don't forget to use the
ratelimiting printk options....

Ian.