From: Vladislav Yasevich <vyasevich@gmail.com>
To: netdev@vger.kernel.org
Cc: jasowang@redhat.com, mst@redhat.com,
Vladislav Yasevich <vyasevic@redhat.com>
Subject: [RFC PATCH net-next 0/3] Extend macvtap with multiple qdiscs
Date: Sun, 7 Feb 2016 22:14:53 -0500 [thread overview]
Message-ID: <1454901296-9915-1-git-send-email-vyasevic@redhat.com> (raw)
This is an RFC series to extend macvtap with multiple qdisc. Right now
multiqueue macvtap setups suffer from lock contention. Macvtap sets
the queue index and thus gets a default qdisc allocated to it. Since
it later users dev_queue_xmit() call to the macvlan type device (so that
we can packet captures and other filtering on macvtap itself) we end up
with qdisc lock contention since what we have is multiple file descriptors
writing to the same qdisc.
With this series, the macvtap device now becomes a true multi-queue device
that defaults to 1 queue. Every time the user opens the device (this is
how multiqueue macvtap is used), we update the number of real queues for
the device. When the user writes to the device, we record the queue index
associted with the file descriptor to the skb, and that ends up translating
to the device queue index. This is one transmit only. Receive side
is left alone and will prefer skb hash if available.
Macvlan through this all is left with lockless transmit path.
Thanks
-vlad
Vladislav Yasevich (3):
macvtap: mutiple qdiscs support
macvlan: add queue selection functionality
macvtap: Record the rx queue based on the user tap queue
drivers/net/macvlan.c | 20 ++++++++++++++++++++
drivers/net/macvtap.c | 19 +++++++++++++++++++
2 files changed, 39 insertions(+)
--
2.1.0
next reply other threads:[~2016-02-08 3:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 3:14 Vladislav Yasevich [this message]
2016-02-08 3:14 ` [RFC PATCH net-next 1/3] macvtap: mutiple qdiscs support Vladislav Yasevich
2016-02-08 3:14 ` [RFC PATCH net-next 2/3] macvlan: add queue selection functionality Vladislav Yasevich
2016-02-08 3:45 ` Eric Dumazet
2016-02-09 4:30 ` Pankaj Gupta
2016-02-08 3:14 ` [RFC PATCH net-next 3/3] macvtap: Record the rx queue based on the user tap queue Vladislav Yasevich
2016-02-23 2:38 ` [RFC PATCH net-next 0/3] Extend macvtap with multiple qdiscs Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454901296-9915-1-git-send-email-vyasevic@redhat.com \
--to=vyasevich@gmail.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).